Add UKCP positions syncing#4965
Open
kristiankunc wants to merge 4 commits into
Open
Conversation
CLC0609
reviewed
Jul 1, 2026
CLC0609
left a comment
CLC0609
left a comment
Contributor
There was a problem hiding this comment.
Other than that all looks good!
CLC0609
approved these changes
Jul 2, 2026
CLC0609
reviewed
Jul 3, 2026
Comment on lines
+140
to
+141
| 'APP', 'APPROACH', 'F_APP', 'N_APP', 'S_APP', 'A_APP', | ||
| 'L_APP', 'D_APP', 'R_APP', 'P_APP', 'Z_APP' => self::TYPE_APPROACH, |
Contributor
There was a problem hiding this comment.
Missed this on my review, but we probably don't need all the *_APP callsigns as the split would only grab the last part anyways right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for BW to review UKCP positions
Adds a scheduled sync (daily at 04:00) that pulls controller positions from the UKCP API into the core positions table. New positions are created, existing ones have frequency/ID updated, and positions removed from UKCP are soft-deleted. Includes ukcp_position_id column, soft deletes on the model, a helper to infer position type from callsign, and removes the unused sub_station column. Supports --dry-run for preview.