rocknix: Update 260810 - #437
Merged
Merged
Conversation
The four colours this script selected between were not four colours. Its "orange" is RGB 255 20 0, measured on hardware as 24.7% duty on the red channel against 1.8% on green, which is indistinguishable from the "red" at 255 0 0. That near-red was also the colour for the entire 0-94% charging range, so a plugged-in device sat on it for hours and looked identical to one about to die. Replace the bands with a continuous sweep: red at empty, yellow at half, green at full. Hue runs 0deg to 120deg with one channel always pinned at full, so output stays constant instead of dipping mid-range the way a naive per-channel interpolation would. Verified by eye on an Odin 2: 25% reads orange, 50% yellow, 75% lime, and the endpoints are single channels so they cannot drift. Two fixes fall out of the rewrite. A status of "Full" or "Not charging" used to reach the charging path by fall-through rather than by intent, and now shows the real level like every other state. An empty or garbled capacity read used to abort the arithmetic, so guard it. The critical blink is kept and is now gated to discharging only, so a critically low but charging device no longer blinks at the user. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The battery LED state functions wrote a literal 255 to the brightness attribute, so the EmulationStation brightness setting had no effect whenever led.color=battery (the default). Add a led_bri() helper that converts led.brightness (percent) to 0-255 and use it for the brightness writes. Colour values and bat_led_off are unchanged, so battery status indication behaves exactly as before -- only the intensity changes. Falls back to 100% if the setting is unset or non-numeric, and clamps to a minimum of 1 so a non-zero percentage never reads as off. Anbernic RG DS already does this (ROCKNIX#2533); this brings the Thor in line.
The resume log line reads "Restoring brightness}." on every wake. The stray brace is left over from 8ff2572, which moved the value into ${BRIGHTNESS} for the dual screen fix but did not carry it into the message, so the one number worth having in the log is the one it does not print. Match the volume line above it and the display 2 line below it, both of which already log their value. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
armsx2: bump to 2.6.6.4
…typo sleep: log the brightness value being restored
thor: honour led.brightness in battery LED mode
…creen rk3576: Fix black screen on first boot
moonlight: fix touchscreen input on hosts without native touch
odin2: ramp the power LED across the whole battery range
Patch 0076: 1792 on the six-core cluster, 1894 on the prime pair, matching the SM8750 Android DT (KONKR dump; Qualcomm sun baseline) instead of equal 1024.
Adds platforms/SM8750/002-turbo-mode_config with DEVICE_TURBO_MODE, matching the other platforms. enable.turbo-mode keeps its default of 0 from the common 095-turbo-mode quirk.
SM8750: enable boost and tweak capacity-dmips-mhz
# Conflicts: # projects/ROCKNIX/packages/emulators/standalone/armsx2-sa/package.mk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES | PARTIALLY | NO