Skip to content

Add "aggregate_credits" to TV AppendToResponseItems #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amcintosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add "aggregate_credits" to TV AppendToResponseItems #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/uwetrottmann/tmdb2/enumerations/AppendToResponseItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public enum AppendToResponseItem {

// Applies to TV Shows
CONTENT_RATINGS("content_ratings"),
AGGREGATE_CREDITS("aggregate_credits"),

// Applies to People
MOVIE_CREDITS("movie_credits"),
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/uwetrottmann/tmdb2/TestData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ private static void initializeTestingIntegrityData() throws ParseException {
testTvShow.external_ids.facebook_id = "TheSimpsons";
testTvShow.external_ids.freebase_mid = "/m/07c72";
testTvShow.external_ids.freebase_id = "/en/the_simpsons";
testTvShow.external_ids.instagram_id= "thesimpsonsfox";
testTvShow.external_ids.instagram_id= "thesimpsons";
testTvShow.external_ids.tvrage_id = 6190;
testTvShow.external_ids.twitter_id = "thesimpsons";
testTvShow.external_ids.wikidata_id = "Q886";
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/uwetrottmann/tmdb2/assertions/TvAssertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public static void assertTvShow(TvShow tvShow) {
}

assertThat(tvShow.episode_run_time).isNotNull();
assertThat(tvShow.episode_run_time).isNotEmpty();
for (Integer runTime : tvShow.episode_run_time) {
assertThat(runTime).isNotNull();
assertThat(runTime).isGreaterThanOrEqualTo(0);
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/uwetrottmann/tmdb2/services/ConfigurationServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ public void primary_translations() throws IOException {
"hi-IN",
"hr-HR",
"hu-HU",
"hy-AM",
"id-ID",
"it-IT",
"it-VA",
Expand Down