Skip to content

Feature/msl 695 consistency database relation models#252

Open
maiknbm wants to merge 145 commits into
developmentfrom
feature/MSL-695_consistency_database_relation_models
Open

Feature/msl 695 consistency database relation models#252
maiknbm wants to merge 145 commits into
developmentfrom
feature/MSL-695_consistency_database_relation_models

Conversation

@maiknbm
Copy link
Copy Markdown
Collaborator

@maiknbm maiknbm commented Apr 23, 2026

steps to complete in order (based on on this confluence page)

  1. establish missing model relations
  2. importer in data repository should be of type hasMany. It should also be named importers since it can return multiple.
  3. create one test for an untested class and then discuss if others should follow
  4. apply return types to the relation functions following guides
  5. Existing and new method names should follow camelCase naming convention

@maiknbm maiknbm requested a review from lsamshuijzen April 23, 2026 08:20
@maiknbm
Copy link
Copy Markdown
Collaborator Author

maiknbm commented Apr 23, 2026

@lsamshuijzen Please review changes for step 1

lsamshuijzen
lsamshuijzen reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lsamshuijzen lsamshuijzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added relations in the models look good.

maiknbm added 20 commits April 23, 2026 13:35
@maiknbm
changed naming to plural: importers(). also relation is now hasMany n…
630227b 
…ot belongsToMany
@maiknbm
added return type importers()
89223e9
@maiknbm
added return types source_dataset() and import()
c0f7c2d
@maiknbm
added relation seed()
fafc72d
@maiknbm
added return types to importer(), source_dataset_identifiers(), sourc…
c1a5401 
…e_datasets() and dataset_creates()
@maiknbm
added relations to data_repository() and imports()
b6b8c7c
@maiknbm
added return type to parent()
f9cb350
@maiknbm
added return type to parent(), vocabulary() and keyword_search()
f0eac40
@maiknbm
added return type to keyword()
9b97503
@maiknbm
added return types to laboratoryOrganization(), laboratoryContactPers…
dbed9dc 
…ons(), laboratoryManager(), laboratoryEquipment(), laboratoryKeywords(), laboratoryUpdatesFast()
@maiknbm
added return type to laboratory()
6e40463
@maiknbm
added return type to seed()
af42f15
@maiknbm
added return types to laboratory(), keyword(), laboratory_equipment_a…
68160fb 
…ddons()
@maiknbm
added return type to laboratory_equipment(), keyword()
90636a9
@maiknbm
added return type to laboratory()
2c03883
@maiknbm
added return types to laboratories()
58ea3ee
@maiknbm
add return type to laboratories(), laboratoryOrganizationUpdateRors()
4439582
@maiknbm
add return type to laboratoryOrganizationUpdateRors()
8d828f9
@maiknbm
add return type to laboratoryOrganizationUpdateGroupRor(), laboratory…
c94603b 
…Organization()
@maiknbm
add return type to laboratoryUpdatesFast()
0a64031
maiknbm added 29 commits May 19, 2026 21:07
@maiknbm
Relations tests for the Model: LaboratoryCreate
6f3abe9
@maiknbm
Relations tests for the Model: EquipmentCreate
3ca1b45
@maiknbm
Relations tests for the Model: OrganizationCreate
3cb44a6
@maiknbm
removed old silly tests
4f7114e
@maiknbm
Relations tests for the Model: LaboratoryOrganizationUpdateGroupRor
d96fa33
@maiknbm
Relations tests for the Model: LaboratoryOrganizationUpdateRor
8676c73
@maiknbm
Relations tests for the Model: LaboratoryOrganization
4b045a5
@maiknbm
Relations tests for the Model: LaboratoryContactPerson
480c012
@maiknbm
Relations tests for the Model: LaboratoryManager
4a406e6
@maiknbm
Relations tests for the Model: LaboratoryUpdateGroupFast
8d9029a
@maiknbm
Relations tests for the Model: LaboratoryKeyword
fa89a13
@maiknbm
Relations tests for the Model: LaboratoryEquipmentAddon
2c7c1ab
@maiknbm
Relations tests for the Model: LaboratoryEquipment
5014b5c
@maiknbm
Relations tests for the Model: LaboratoryUpdateFast
8e6deb4
@maiknbm
Relations tests for the Model: Laboratory
521e1f2
@maiknbm
removed old silly tests
0bd2916
@maiknbm
Minimal test setup correction: LaboratoryContactPerson
3cd7bab
@maiknbm
Minimal test setup correction: LaboratoryEquipmentAddon
84d06c7
@maiknbm
Minimal test setup correction: LaboratoryKeyword
97ccf5b
@maiknbm
Minimal test setup correction: LaboratoryManager
b5f2b45
@maiknbm
Minimal test setup correction: LaboratoryOrganization
bbfc997
@maiknbm
Minimal test setup correction: LaboratoryUpdateFast
78d2a23
@maiknbm
Minimal test setup correction: LaboratoryUpdateGroupFast
e2ead4f
@maiknbm
survey test rename
4cf8053
@maiknbm
Relations tests for the Model: QuestionType
4ae1f15
@maiknbm
Relations tests for the Model: Answer
7ab6343
@maiknbm
Relations tests for the Model: Response
4fb4750
@maiknbm
Relations tests for the Model: Question
cdfa7f3
@maiknbm
Relations tests for the Model: Survey
499f255
@maiknbm
Copy link
Copy Markdown
Collaborator Author

maiknbm commented May 21, 2026

Hey @lsamshuijzen
please review again. Your comments were included. Although, maybe it makes sense to mirror the folder structure of the app\Models folder and place the survey related ones under tests\Feature\Models\Surveys\ . Currently, all tests are in tests\Feature\Models\ as requested.
Regarding your last point I was not sure how you meant it. For now each test-function in each model test file has the required setup individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsamshuijzen lsamshuijzen lsamshuijzen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maiknbm @lsamshuijzen