refactor: pipeline bug fixes, restored auth package, CI/CD pipeline, and research-grade README overhaul - #2
Merged
Conversation
…e, and research-grade README overhaul
…add python-multipart + httpx, move onnxruntime-gpu to [gpu] extra
- typer 0.12.x has a known regression with click 8.2 ('Secondary flag is not
valid for non-boolean flag') - downgrade ceiling to <0.12.0
- FastAPI form endpoints require python-multipart at runtime, add to core deps
- httpx is required by starlette TestClient, add to core deps
- onnxruntime-gpu fails on CPU-only CI runners (ubuntu-latest); move to
optional [gpu] extra, keep CPU onnxruntime in core deps so CI installs clean
- Simplify ci.yml to single pip install -e .[dev] - all version pinning
is now managed in pyproject.toml (single source of truth)
…None compat typer 0.11.x (and earlier) cannot introspect 'str | None' union type hints when from __future__ import annotations is active (it stringifies all annotations, turning the actual type into a string literal that typer cannot evaluate). Python 3.11+ supports PEP 604 union syntax natively at runtime so the __future__ import is not needed. Root cause: CI installed typer==0.11.1 which calls get_click_type() on the string 'str | None' and raises RuntimeError: Type not yet supported. Fix: remove from __future__ import annotations from cli.py — typer now receives the actual str | None UnionType object (Python 3.10+), which all tested typer versions handle correctly without the __future__ shim. Also broadened typer constraint to >=0.9.0,<0.13.0 now that the source code is compatible with the full range.
click 8.2.0 introduced stricter validation in Option.__init__() that raises 'Secondary flag is not valid for non-boolean flag' when secondary_opts is set on a non-boolean Option. typer 0.9.x-0.11.x passes secondary_opts when generating --rebuild/--no-rebuild bool flag pairs via TyperOption without properly setting is_bool_flag=True first, hitting the new check. CI was installing click-8.4.2 which introduced this regression vs typer's TyperOption implementation. Pin click<8.2.0 (8.1.8 is the latest safe version) until we can upgrade to typer>=0.12.3 which properly handles this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
1. Bug Fixes & Test Suite Restoration (100% Pass Rate: 72/72 Tests)
trace_aml.authPackage: ImplementedGoogleBrowserOAuthClient,GoogleIdentityVerifier,RemoteAuthPolicyClient(open access policy),DesktopSessionManager, andBrowserAuthFlowManager.IncidentManager.handle_alert()to return(updated, "on_update")for continuous detections on open incidents.decide_person_lifecycle()so candidate profiles with valid images remain indraftstate until readiness criteria are met.ArcFaceRecognizer._ensure_app()to use./models/buffalo_llocal path when pre-downloaded model assets exist.2. CI/CD Pipeline Integration
.github/workflows/ci.ymlrunningpytestandrufflinting across Python 3.11 and 3.12 matrices.[tool.ruff]linter configuration topyproject.toml.3. Data Sanitization & Security
config/config.demo.yamlwith generic standard placeholders.4. Research-Grade & Formal README.md Overhaul
flowchart LR), Component Topology (flowchart TB), and Identification Sequence (sequenceDiagram).Verification
pytest -v: 72 passed in 14.95s (100% pass rate).