fix: deeplinks to Proposal and Experiment#1665
Open
shivoomiess wants to merge 2 commits into
Open
Conversation
shivoomiess
requested review from
jekabs-karklins,
yoganandaness and
zacharyjhankin
July 22, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a fix for deeplinks to Proposal and Experiment in the frontend for the User Officer.
Motivation and Context
The change was required to fix the issue where deeplinks to Proposal and Experiment were not functioning as expected. This was breaking links from the Experiments page to Proposals that were not already loaded in the Proposals Table (due to pagination) on the ESS dev instance because it has much more data than a local dev environment.
Before this change, a Proposal or Experiment not already loaded in the relevant table rows did not open up the details modal if directly accessed from a link because the data was never fetched.
Changes
ExperimentsTable.tsx,ProposalTableOfficer.tsx, similar changes are made to correctly parse the proposal identifier from the URL and fetch the proposal data. A fallback mechanism is also added here to fetch proposal data by primary key if it is not found in the current page of results.How Has This Been Tested?
A dump of the Dev DB was taken today and we ensured that all Proposals were clickable and redirected to the correct Proposal View. For experiments, since there are currently no links on the frontend redirecting to a particular experiment, we tried to access an experiment's details using a deep link.
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5680
Depends On
Tests included/Docs Updated?