Migrate the remaining console apps onto the shared route tree - #955
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 2fd8c44 | Commit Preview URL Branch Preview URL |
Jun 11 2026, 11:19 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 2fd8c44 | Jun 11 2026, 11:19 PM |
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
from
June 11, 2026 22:38
c5764fa to
69ba79e
Compare
RhysSullivan
force-pushed
the
claude/console-route-contract
branch
2 times, most recently
from
June 11, 2026 22:38
0ea4fd0 to
4c7fa3a
Compare
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
from
June 11, 2026 22:38
69ba79e to
b7bc241
Compare
RhysSullivan
force-pushed
the
claude/console-route-contract
branch
from
June 11, 2026 22:45
4c7fa3a to
a43a19c
Compare
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
from
June 11, 2026 22:45
b7bc241 to
a40fc87
Compare
RhysSullivan
force-pushed
the
claude/console-route-contract
branch
from
June 11, 2026 22:46
a43a19c to
44ee726
Compare
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
2 times, most recently
from
June 11, 2026 23:00
9c7ba75 to
b065ccc
Compare
RhysSullivan
force-pushed
the
claude/console-route-contract
branch
from
June 11, 2026 23:00
44ee726 to
a50c721
Compare
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
claude/console-route-contract
branch
from
June 11, 2026 23:10
a50c721 to
9321b63
Compare
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
from
June 11, 2026 23:10
b065ccc to
93c6e74
Compare
packages/app (local + desktop), host-selfhost, and cloud now compose consoleRoutes() from @executor-js/react into their TanStack virtualRouteConfig instead of re-declaring the shared route files — host-cloudflare already did in the previous commit. Each app keeps its own __root and its app-specific routes under a routes/app directory. Intentional divergence is now explicit via exclude: - packages/app excludes /secrets (the local variant shows credential-provider info). - cloud excludes /secrets (redirects to /), /resume/$executionId (the cloud variant), and /plugins/$pluginId/$ (client plugin pages are not wired up on cloud). The legacy /sources/* redirect stubs are dropped rather than carried forward — pre-rename bookmarks now 404 instead of redirecting. Incidental drift the shared files erase: local/desktop pick up the integration-add namespace search param the other apps already had. A contract test in packages/react locks consoleRoutes() to the generated console tree, so a route file added without a helper entry (or vice versa) fails in CI. cloud's build wrapper additionally pre-builds @executor-js/react: its vite config imports @executor-js/react/console-routes, which vite's config loader externalizes, so under Node it must resolve to the built dist.
RhysSullivan
force-pushed
the
claude/shared-console-routes
branch
from
June 11, 2026 23:16
93c6e74 to
2fd8c44
Compare
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #954: packages/app (local + desktop), host-selfhost, and cloud now compose
consoleRoutes()into their TanStackvirtualRouteConfig— cloud through Start'srouteroption — instead of re-declaring the shared route files. Each app keeps its own__rootand moves its app-specific routes underroutes/app/.Intentional divergence becomes explicit via
exclude:/secrets(the local variant shows credential-provider info)./secrets(redirects to/),/resume/$executionId(the cloud variant), and/plugins/$pluginId/$(client plugin pages aren't wired up on cloud).The legacy
/sources/*redirect stubs are dropped rather than carried forward — pre-rename bookmarks now 404 instead of redirecting.Incidental drift the shared files erase: local/desktop pick up the integration-add
namespacesearch param the other apps already had. Net −326 lines.A contract test in packages/react locks
consoleRoutes()to the generated console tree, so a route file added without a helper entry (or vice versa) fails in CI.All four apps build; repo-wide format/lint/typecheck/test gates pass.
Stack