refactor(errors): make ToolInvocationError schema-backed - #883
Closed
RhysSullivan wants to merge 1 commit into
Closed
refactor(errors): make ToolInvocationError schema-backed#883RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Convert `ToolInvocationError` from `Data.TaggedError` to `Schema.TaggedErrorClass` (`cause` -> `Schema.optional(Schema.Defect)`). It was the only non-schema member of the `ExecutorError` union, so the whole union — which is returned across the SDK/MCP wire — is now fully schema-encodable. The remaining `Data.TaggedError` errors are internal or mapped to `ToolResult` before the wire (the module-private exception), so they stay as-is. Verified: typecheck (all 38 packages), lint (0/0), format, sdk tests.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 8947866 | Jun 02 2026, 05:49 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 8947866 | Commit Preview URL Branch Preview URL |
Jun 02 2026, 05:48 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
ToolInvocationErrorschema-backed.It was the only
Data.TaggedErrorin the 16-memberExecutorErrorunion, so converting it (cause→Schema.optional(Schema.Defect)) makes the whole union — which is returned across the SDK/MCP wire — fully schema-encodable.Investigation showed the remaining
Data.TaggedErrorerrors are either internal or mapped to aToolResultfailure before the wire (the "module-private" exception), so they intentionally stay asData. This is a tighter scope than the original audit assumed — the error model was closer to good than expected.Stacked on #882.
Verified: typecheck (all 38 packages), lint (0/0), format, sdk tests.
Draft.