[codex] Merge Google Discovery plugin into OpenAPI - #867
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 0b2be3f | Commit Preview URL Branch Preview URL |
May 29 2026, 02:06 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 0b2be3f | May 29 2026, 02:06 AM |
RhysSullivan
changed the title
RhysSullivan
commented
May 29, 2026
Comment on lines
+383
to
+409
| const slugifyCredentialSlotPart = (value: string): string => | ||
| value | ||
| .trim() | ||
| .toLowerCase() | ||
| .replace(/[^a-z0-9]+/g, "-") | ||
| .replace(/^-+|-+$/g, "") || "default"; | ||
|
|
||
| const openApiHeaderSlot = (name: string): string => `header:${slugifyCredentialSlotPart(name)}`; | ||
|
|
||
| const openApiQueryParamSlot = (name: string): string => | ||
| `query_param:${slugifyCredentialSlotPart(name)}`; | ||
|
|
||
| const googleOAuthSecuritySchemeName = "googleOAuth2"; | ||
|
|
||
| const googleOAuthSlotPart = slugifyCredentialSlotPart(googleOAuthSecuritySchemeName); | ||
|
|
||
| const googleOAuthClientIdSlot = `oauth2:${googleOAuthSlotPart}:client-id`; | ||
| const googleOAuthClientSecretSlot = `oauth2:${googleOAuthSlotPart}:client-secret`; | ||
| const googleOAuthConnectionSlot = `oauth2:${googleOAuthSlotPart}:connection`; | ||
|
|
||
| const randomRowId = (): string => randomBytes(12).toString("hex"); | ||
|
|
||
| const textDecoder = new TextDecoder(); | ||
| const decodeJsonColumn = Schema.decodeUnknownOption(Schema.fromJsonString(Schema.Unknown)); | ||
|
|
||
| const parseJsonColumn = (value: string | Uint8Array | null | undefined): unknown => { | ||
| if (!value) return undefined; |
Collaborator
Author
There was a problem hiding this comment.
dont put migration logic into core executor.ts file, put it into its own file
RhysSullivan
commented
May 29, 2026
Comment on lines
+414
to
+434
| const jsonObject = (value: unknown): Record<string, unknown> => | ||
| value !== null && typeof value === "object" && !Array.isArray(value) | ||
| ? (value as Record<string, unknown>) | ||
| : {}; | ||
|
|
||
| const stringArrayFromJson = (value: unknown): string[] => | ||
| Array.isArray(value) ? value.filter((item): item is string => typeof item === "string") : []; | ||
|
|
||
| const stringValue = (value: unknown): string | undefined => | ||
| typeof value === "string" && value.length > 0 ? value : undefined; | ||
|
|
||
| const googleSchemaRef = (name: string): string => `#/$defs/${name}`; | ||
|
|
||
| const openApiPluginStorageId = (collection: string, key: string): string => | ||
| JSON.stringify(["openapi", collection, key]); | ||
|
|
||
| const openApiCredentialBindingId = (scopeId: string, sourceId: string, slot: string): string => | ||
| JSON.stringify(["openapi", scopeId, sourceId, slot]); | ||
|
|
||
| type GoogleSourceRow = { | ||
| readonly id: string; |
Collaborator
Author
There was a problem hiding this comment.
brother use parsing
RhysSullivan
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
just remove this completely it isnt used
RhysSullivan
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
is there an existing converter we can use
Collaborator
Author
There was a problem hiding this comment.
can we just convert google discovery -> openapi
RhysSullivan
force-pushed
the
codex/remove-google-discovery-plugin
branch
3 times, most recently
from
May 29, 2026 01:53
1f33f12 to
f8ec475
Compare
RhysSullivan
force-pushed
the
codex/remove-google-discovery-plugin
branch
from
May 29, 2026 02:04
f8ec475 to
0b2be3f
Compare
RhysSullivan
marked this pull request as ready for review
May 29, 2026 02:11
RhysSullivan
added a commit
that referenced
this pull request
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun run lintbun run format:checkbun run typecheckbunx --bun vitest run src/sdk/index.test.ts src/sdk/query-serialization.test.tsinpackages/plugins/openapibunx --bun vitest run src/server/google-discovery-openapi-migration.test.tsinapps/localbunx --bun vitest run src/components/source-favicon.test.tsxinpackages/reactbunx --bun vitest run tests/presets-reachable.test.ts --testNamePattern 'public preset URLs are detected'bun run dev:cli -- call gmail_api.users.messages.list ...