Skip to content

Report real surface and version in registry user-agent #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Aug 5, 2026
Merged

Report real surface and version in registry user-agent #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"@executor-js/plugin-openapi",
"@executor-js/plugin-example",
"@executor-js/plugin-desktop-settings",
"@executor-js/desktop"
"@executor-js/desktop",
"@executor-js/local"
]
],
"linked": [],
Expand All @@ -29,7 +30,6 @@
"onlyUpdatePeerDependentsWhenOutOfRange": true
},
"ignore": [
"@executor-js/local",
"@executor-js/host-mcp",
"@executor-js/ir",
"@executor-js/runtime-deno-subprocess",
Expand Down
6 changes: 6 additions & 0 deletions .changeset/tidy-donkeys-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"executor": patch
"@executor-js/local": patch
---

Report the real product surface and version in the integrations.sh registry user-agent. The daemon previously sent `local` with a version frozen at 1.4.4; it now reports `cli` or `desktop` (matching analytics surfaces) and `@executor-js/local` is versioned with the release train.
9 changes: 5 additions & 4 deletions apps/local/src/installation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ const resolveChannel = (version: string): InstallationChannel => {
return "stable";
};

// The desktop main process sets `EXECUTOR_CLIENT=desktop` when it spawns the
// sidecar so PostHog can slice desktop installs from headless apps/local
// (CLI `executor web`, `daemon run --foreground`, etc.).
// The surface is cli|desktop — never a "local" catch-all: the desktop main
// process marks its sidecar via EXECUTOR_CLIENT=desktop; everything else
// hosting apps/local (`executor web`, `daemon run --foreground`, stdio MCP)
// is the CLI. Mirrors resolveSurface in ./analytics.ts.
const resolveClient = (): SurfaceClient =>
process.env.EXECUTOR_CLIENT === "desktop" ? "desktop" : "local";
process.env.EXECUTOR_CLIENT === "desktop" ? "desktop" : "cli";

export const CHANNEL: InstallationChannel = resolveChannel(LOCAL_VERSION);
export const VERSION: string = LOCAL_VERSION;
Expand Down
4 changes: 2 additions & 2 deletions packages/core/integrations-registry/src/registry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ describe("buildUserAgent", () => {
expect(buildUserAgent({ channel: "stable", version: "1.2.3", client: "cli" })).toBe(
"executor/stable/1.2.3/cli",
);
expect(buildUserAgent({ channel: "beta", version: "1.2.3-beta.0", client: "local" })).toBe(
"executor/beta/1.2.3-beta.0/local",
expect(buildUserAgent({ channel: "beta", version: "1.2.3-beta.0", client: "desktop" })).toBe(
"executor/beta/1.2.3-beta.0/desktop",
);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/core/integrations-registry/src/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { NodeFileSystem } from "@effect/platform-node";
// ---------------------------------------------------------------------------

export type InstallationChannel = "stable" | "beta" | "dev";
export type SurfaceClient = "cli" | "local" | "desktop";
export type SurfaceClient = "cli" | "desktop";

export const DEFAULT_INTEGRATIONS_URL = "https://integrations.sh/api.json";

Expand Down
Loading