Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/revert-hosted-dns-guard.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@executor-js/sdk": patch
---

Revert the hosted outbound DNS guard resolution cache and the accompanying outbound guard changes released in 1.5.38. The guard returns to its previous behavior: no resolution cache, the caller's `redirect` mode is not honored, and `makeHostedHttp` is no longer exported — use `makeHostedFetch` and `makeHostedHttpClientLayer` as before.
17 changes: 9 additions & 8 deletions packages/core/api/src/server/scoped-executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ import {
type ExecutorConfig,
type StorageFailure,
} from "@executor-js/sdk";
import { makeHostedHttp, touchSubject } from "@executor-js/sdk/host-internal";
import {
makeHostedFetch,
makeHostedHttpClientLayer,
touchSubject,
} from "@executor-js/sdk/host-internal";

import { DbProvider } from "./executor-fuma-db";

Expand Down Expand Up @@ -265,10 +269,8 @@ export const makeScopedExecutor = <
const hostedHttpOptions = {
allowLocalNetwork: config.allowLocalNetwork,
};
// One resolution cache behind both adapters: the plugins take the raw
// fetch and the SDK takes the layer, so building them separately would
// resolve every hostname twice per session.
const { fetch: hostedFetch, httpClientLayer } = makeHostedHttp(hostedHttpOptions);
const httpClientLayer = makeHostedHttpClientLayer(hostedHttpOptions);
const hostedFetch = makeHostedFetch(hostedHttpOptions);

// The org id is the tenant (catalog partition); the account id is the acting
// subject (drives `owner: "user"` rows). `organizationName` is no longer part
Expand Down Expand Up @@ -361,15 +363,14 @@ export const makePlatformExecutor = (
Effect.withSpan("executor.platform.plugins.init"),
);
const hostedHttpOptions = { allowLocalNetwork: config.allowLocalNetwork };
const platformHttp = makeHostedHttp(hostedHttpOptions);

return yield* createExecutor({
tenant: Tenant.make(organizationId),
db,
blobs,
plugins,
httpClientLayer: platformHttp.httpClientLayer,
fetch: platformHttp.fetch,
httpClientLayer: makeHostedHttpClientLayer(hostedHttpOptions),
fetch: makeHostedFetch(hostedHttpOptions),
onElicitation: "accept-all",
platformView: true,
}).pipe(Effect.withSpan("executor.platform.create_executor"));
Expand Down
1 change: 0 additions & 1 deletion packages/core/sdk/src/host-internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
export {
HostedOutboundRequestBlocked,
makeHostedFetch,
makeHostedHttp,
makeHostedHttpClientLayer,
type HostedHttpClientOptions,
} from "./hosted-http-client";
Expand Down
Loading
Loading