upipe_h265_framer: Fix chroma_array_type derivation#1166
Merged
Conversation
Fixes vsize on 10-bit 4:2:0 streams
Contributor
|
Is this right? I'm hardly familiar with the spec Table 6-1 says that the chroma subsampling is 1 for monochrome and 4:4:4 (obviously). Those modes are indicated with a combination of chroma_format_idc and separate_colour_plane_flag. Monochrome being 0 and 0 and 4:4:4 being 3 and 0 or 3 and 1. I'm not sure what chroma_array_type is supposed to be since it is only a local variable. If separate_colour_plane_flag can only be set for chroma_format_idc=3 then ... maybe? It is only read from the bitstream when chroma_format_idc=3. What about fuzzing or malformed streams? Ultimately I don't know enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vsize on 10-bit 4:2:0 streams