fix: resolve #2 - #11
Open
Shaidyk wants to merge 1 commit into
Open
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2.
Turned the standalone x86_64 copy-engine into a real daemon and wired it into Coolify's actual backup stack. (1)
backup-daemon.snow implements the scheduling-loop layer the issue requires — a--every <seconds>daemon mode (copy →fsync→nanosleep→ repeat) and a--fsync <path>durability mode — alongside the existing one-shot copy. (2) The binary is assembled (amd64-only, guarded) and installed at/usr/local/bin/coolify-backup-daemoninside the helper image (docker/coolify-helper/Dockerfile) — the image Coolify already runs on the managed server during backups. (3)DatabaseBackupJob::flushBackupToDisk()invokes the daemon in--fsyncmode after every dump, so a reported-good backup is actually flushed to disk on the real backup path (opportunistic, never fails a backup). (4) Addedtests/Feature/BackupDaemonPackagingTest.php, which runs in Coolify's Pest/PHP CI (mirroring the existingRealtimeTerminalPackagingTest), plus extended thenode:testsuite for the new modes, and made the helper workflow rebuild when the asm changes./claim #2