fix(docs): resolve schemas without bundling to preserve type links#551
Open
dantsai wants to merge 1 commit into
Open
fix(docs): resolve schemas without bundling to preserve type links#551dantsai wants to merge 1 commit into
dantsai wants to merge 1 commit into
Conversation
Contributor
|
Thanks for this PR! During local verification, I noticed that this change introduces one broken link regression in the generated documentation for the "Catalog Lookup" page. You can resolve this by updating docs/specification/catalog/lookup.md to target "catalog/lookup" in the macro calls and explicitly rendering the "detail_product" schema at the end of the "Get Product" section. Example: From {{ extension_schema_fields('catalog_lookup.json#/$defs/lookup_response', 'catalog') }} |
1f45442 to
d51323c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This corrects links in the specification reference docs, specifically for the Type column.
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
N/A