Skip to content

chore: upgrade actions for Node 24 compatibility#44

Merged
damaz91 merged 2 commits into
Universal-Commerce-Protocol:mainfrom
dantsai:ci/upgrade-actions-node24
Jun 17, 2026
Merged

chore: upgrade actions for Node 24 compatibility#44
damaz91 merged 2 commits into
Universal-Commerce-Protocol:mainfrom
dantsai:ci/upgrade-actions-node24

Conversation

@dantsai

@dantsai dantsai commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

update workflows/actions for node24 deprecation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Pull Request Title

This repository enforces Conventional Commits. Your PR title must follow
this format: type: description or type!: description for breaking changes.

Types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space,
    formatting, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • chore: Changes to the build process or auxiliary tools and libraries

Breaking Changes:

If your change is a breaking change (e.g., removing a field or file), you
must add ! before the colon in your title:
type!: description

Examples:

  • feat: add new payment gateway
  • fix: resolve crash on checkout
  • docs: update setup guide
  • feat!: remove deprecated buyer field from checkout

@dantsai dantsai requested review from a team as code owners June 16, 2026 19:30
@ptiper ptiper added the devops label Jun 16, 2026

@ptiper ptiper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dan,

Many thanks for the updates!

Similar to the .github PR, could we add a comment in .github/workflows/pre-commit.yml explaining why we need FORCE_JAVASCRIPT_ACTIONS_TO_NODE24?

Also, if you've already created an issue to track migrating away from pre-commit/action (since it's in maintenance mode), could you link it here? Otherwise, please open one to track it.

Best regards,
Guillaume

added comment to note pre-commit/action workaround
@ptiper ptiper requested a review from damaz91 June 17, 2026 10:49
@damaz91 damaz91 merged commit f983204 into Universal-Commerce-Protocol:main Jun 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants