Skip to content

Stabilize Temporal qualification timing #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydixon22 merged 1 commit into from
Aug 18, 2026
Merged

Stabilize Temporal qualification timing #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/Vyral.Tests.Temporal/TemporalContainerExecutionRuntimeConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ private sealed class ContinueAsNewHandler : IExecutionHandler
{
public const string HandlerId = "qualification.temporal.continue-as-new";
public const int CycleCount = 18;
private static readonly TimeSpan CycleDelay = TimeSpan.FromMilliseconds(300);
private const string CheckpointKey = "continue-as-new-cycles";

public ExecutionHandlerDescriptor Descriptor { get; } = new()
Expand All @@ -827,9 +828,11 @@ public async Task<ExecutionRunResult> ExecuteAsync(IExecutionRunContext context,
while (completedCycles < CycleCount)
{
var nextCycle = completedCycles + 1;
// Keep the timer ahead of a persistence round trip so every cycle exercises
// the durable suspend/resume path rather than the valid immediate-elapsed path.
_ = await context.WaitForTimerAsync(
$"continue-as-new-{nextCycle}",
DateTime.UtcNow.AddMilliseconds(50),
DateTime.UtcNow.Add(CycleDelay),
ct: ct);
completedCycles = nextCycle;
await context.PutCheckpointAsync(new ExecutionCheckpointWrite
Expand Down
Loading