Extend uipath-tasks skill: catalogs, comments, labels, metadata, data - #2562
Extend uipath-tasks skill: catalogs, comments, labels, metadata, data#2562de-si wants to merge 1 commit into
Conversation
|
Claude finished @de-si's task in 5m 0s —— View job Coder-eval task lint (advisory)4 task YAMLs changed; verdicts: 0 Critical, 1 High, 2 Medium, 1 Low, 0 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run❌ High — PR body says "Every command verified live against the test tenant" but does not claim the coder-eval tasks themselves were run and passed. Please edit the PR description to add a line like: Per-task lint
|
|
Claude finished @de-si's task in 2m 39s —— View job PR Review: Extend uipath-tasks skill
SummaryExtends the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Valid YAML, name matches folder, description 323 chars |
| E2E Tests | Issue | expected_turns > max_turns in e2e; missing mode:*/lifecycle:* tags on all 4 tasks |
| Skill Body | OK | Critical Rules, Navigation, When to Use — all properly extended |
| References & Assets | OK | 3 new references, kebab-case, all links resolve, no cross-skill deps |
| Repo Hygiene | OK | CODEOWNERS already covers both paths; no secrets; skill-status.json has entry |
Issues for Manual Review
- CLI command accuracy — The new
uip taskssubcommands (catalogs list/get/create/update,comments,add-comment,labels,metadata,data,save-data) and their flags should be verified against the current CLI version. The PR claims live verification — domain owners should confirm flag names and response codes match the actual API. save-datatype routing — The claim thatsave-dataresolves task type automatically (no--typeflag needed) is a key behavioral assertion. If the CLI changes this, both the reference and the smoke test'scommand_not_executedguard would need updating.
Conclusion
Clean, well-structured PR. The skill additions are consistent, prescriptive, and follow repo conventions. Two actionable items:
- Medium — Fix
expected_turns/max_turnsmismatch ine2e_catalogs_and_annotations.yaml - Medium — Add required
mode:*andlifecycle:*tags to all 4 new test tasks (pre-existing gap in this skill, but new tasks should set the standard)
Neither blocks merge — both are quality improvements that can land in a follow-up if preferred.
1db65bd to
62d1fb5
Compare
…ls, metadata, data Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
62d1fb5 to
04efb32
Compare
Extends the
uipath-tasksskill and evals for the newuip taskscommands: catalogs, comments, labels, metadata, and data. Adds 3 references, 3 smoke evals, and 1 e2e eval.Verification: every command these evals exercise was run live against the test tenant (
procodeapps/integrationtest) and returnedSuccess— catalogs create/get/update/list, data get/save, comments list/add, labels set/clear, metadata note/catalog-id/unset. Smoke evals run through coder-eval in CI. A full coder-eval pass of the e2e eval is gated on the CLI release, since the sandbox installs@uipath/cli@latest, which does not yet include these commands.Jira: https://uipath.atlassian.net/browse/ACTN-11600
🤖 Generated with Claude Code