fix(maestro-case): preserve SDD filter literals when FilterBuilder is absent - #2555
Open
song-zhao-25 wants to merge 3 commits into
Open
fix(maestro-case): preserve SDD filter literals when FilterBuilder is absent#2555song-zhao-25 wants to merge 3 commits into
song-zhao-25 wants to merge 3 commits into
Conversation
song-zhao-25
marked this pull request as ready for review
August 11, 2026 02:45
song-zhao-25
requested review from
abhiram-vad,
charlesliu9 and
jundayin
as code owners
August 11, 2026 02:45
… absent No-FilterBuilder was categorically equated with no server-side filtering, so implementation dropped SDD-declared filter literals that the connector contract accepts as plain query parameters (runtime-verified: Outlook 365 ListEmails declares queryParameters.filter, "Additional OData filters"). - planning: spec.filter undefined rules out structured CEQL authoring only; SDD literals matching declared plain fields stay in input-values - impl Step 4: ordered recovery on FilterBuilder rejection (declared plain field -> native-syntax literal -> downstream filtering last) - impl Post-Write check 12: lossless-inputs hard gate — planned inputs must survive into the written task, halt instead of warn - scope raw-CEQL anti-pattern to FilterBuilder operations Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
song-zhao-25
force-pushed
the
fix/case-filter-literal-recovery
branch
from
August 11, 2026 02:51
1aff653 to
604f068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The skill equated a missing design-time
FilterBuilderwith no server-side filtering. Whencase spec --input-detailsrejected a structuredfilter:tree, implementation could drop an SDD-declared filter even when the connector exposed it as a normal request field.Observed on Outlook 365
ListEmails: the generated case omitted the required subject filter, while the known-good case preserved the native OData literal atqueryParameters.filter.Root cause
spec.filterdescribes structured designer filter support only. A connector may independently expose a native filter field throughinputs.queryParameters[]orinputs.bodyFields[]. These paths use connector-native syntax and must remain in their declared request container.Changes
spec.filter: undefinedas no structured filter authoring only. Preserve an SDD literal exactly under the spec-declared query/body sink. If neither a FilterBuilder nor a plain field can represent the requirement, halt before writingtasks.md; never drop it or invent downstream processing.filter:before callingcase spec. For a malformed legacy plan, recover only the exact value from the authoritative SDD (or same-session confirmed model), repair the existing T-entry in place, preserve its sink and siblings, then rebuild--input-details. Never translate FilterTree/CEQL into OData or another native dialect.Validation
quick_validate.py skills/uipath-maestro-casehooks/validate-skill-descriptions.shgit diff --checkThe existing CM-Golden semantic check already asserts the exact Outlook ListEmails filter value. The live tenant evaluation was not rerun for this follow-up.
Out of scope
Equivalent wording in other owning skills remains for separate owner review.