Skip to content

fix(apollo-vertex): correct empty component border and docs structure - #961

Open
hfrancis31 wants to merge 1 commit into
mainfrom
fix/vertex-empty-component
Open

fix(apollo-vertex): correct empty component border and docs structure#961
hfrancis31 wants to merge 1 commit into
mainfrom
fix/vertex-empty-component

Conversation

@hfrancis31

Copy link
Copy Markdown
Collaborator

Summary

  • Adds missing border class to Empty so the dashed outline actually renders (was border-dashed without border)
  • Rewrites all three page.mdx examples to use the correct shadcn component hierarchy: EmptyHeader wrapping EmptyMedia + title + description, EmptyContent for action buttons
  • Updates the Usage code block in docs to match the corrected structure

Test plan

  • Visit /components/empty and confirm the dashed border is visible on all three examples
  • Confirm icon, title, and description are correctly grouped inside EmptyHeader
  • Confirm the "With Action" example renders the button inside EmptyContent

🤖 Generated with Claude Code

…ture

Add missing `border` class to Empty so the dashed outline renders, and
rewrite the page.mdx examples to use the correct shadcn component
hierarchy (EmptyHeader, EmptyMedia, EmptyContent wrappers).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 23, 2026 20:46
@hfrancis31
hfrancis31 requested a review from a team as a code owner July 23, 2026 20:46
@github-actions github-actions Bot added app:apollo-vertex size:M 30-99 changed lines. labels Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1950 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1720
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Empty component presentation in Apollo Vertex by ensuring its dashed outline renders correctly, and updates the Empty component docs to reflect the intended shadcn-style composition (EmptyHeader + EmptyMedia, with actions in EmptyContent).

Changes:

  • Add missing border class to the Empty container so border-dashed produces a visible outline.
  • Update /components/empty MDX examples to use EmptyHeader, EmptyMedia, and EmptyContent structure.
  • Update the docs “Usage” section to match the corrected component hierarchy.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/apollo-vertex/registry/empty/empty.tsx Adds border to ensure the dashed empty-state outline is visible.
apps/apollo-vertex/app/components/empty/page.mdx Rewrites examples and usage docs to use the intended EmptyHeader/EmptyMedia/EmptyContent layout.

Comment on lines 67 to 71
import {
Empty,
EmptyDescription,
EmptyHeader,
EmptyMedia,
EmptyTitle,
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.84 MB 57.45 MB ±0
@uipath/apollo-react 37.6% 7.40 MB 28.30 MB ±0
@uipath/apollo-wind 41.1% 399.2 KB 2.59 MB −17 B
@uipath/ap-chat 85.8% 43.43 MB 55.93 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:M 30-99 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants