fix(apollo-vertex): correct empty component border and docs structure - #961
fix(apollo-vertex): correct empty component border and docs structure#961hfrancis31 wants to merge 1 commit into
Conversation
…ture Add missing `border` class to Empty so the dashed outline renders, and rewrite the page.mdx examples to use the correct shadcn component hierarchy (EmptyHeader, EmptyMedia, EmptyContent wrappers). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the Empty component presentation in Apollo Vertex by ensuring its dashed outline renders correctly, and updates the Empty component docs to reflect the intended shadcn-style composition (EmptyHeader + EmptyMedia, with actions in EmptyContent).
Changes:
- Add missing
borderclass to theEmptycontainer soborder-dashedproduces a visible outline. - Update
/components/emptyMDX examples to useEmptyHeader,EmptyMedia, andEmptyContentstructure. - Update the docs “Usage” section to match the corrected component hierarchy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/apollo-vertex/registry/empty/empty.tsx | Adds border to ensure the dashed empty-state outline is visible. |
| apps/apollo-vertex/app/components/empty/page.mdx | Rewrites examples and usage docs to use the intended EmptyHeader/EmptyMedia/EmptyContent layout. |
| import { | ||
| Empty, | ||
| EmptyDescription, | ||
| EmptyHeader, | ||
| EmptyMedia, | ||
| EmptyTitle, |
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
Summary
borderclass toEmptyso the dashed outline actually renders (wasborder-dashedwithoutborder)page.mdxexamples to use the correct shadcn component hierarchy:EmptyHeaderwrappingEmptyMedia+ title + description,EmptyContentfor action buttonsTest plan
/components/emptyand confirm the dashed border is visible on all three examplesEmptyHeaderEmptyContent🤖 Generated with Claude Code