Skip to content

CWMVUE-634 Implements Access To Water ("Published") Endpoint#1030

Merged
rma-bryson merged 3 commits into
developfrom
feature/Adding_Access_To_Water_Endpoint
Jun 8, 2026
Merged

CWMVUE-634 Implements Access To Water ("Published") Endpoint#1030
rma-bryson merged 3 commits into
developfrom
feature/Adding_Access_To_Water_Endpoint

Conversation

@rma-bryson

Copy link
Copy Markdown
Collaborator

No description provided.

@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from 0670b66 to 1d4ecf3 Compare February 25, 2025 22:51

@adamkorynta adamkorynta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type" is a bit ambiguous, especially that is is describing the type of parameter (but not to be confused with parameter type inst/ave/const/etc). otherwise the structure looks good. I'd probably prefer parameter even if it doesn't exactly match the parameter in the time series identifier.

@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from 41be4ec to 4950f40 Compare February 27, 2025 17:08
@MikeNeilson

Copy link
Copy Markdown
Contributor

I don't hate it, but it's not giving me any warm and fuzzies for the future either.

@jeffsuperglide, @adamscarberry can you grant @rma-bryson and @adamkorynta at least read access to the access to water repositories to see how you're using the various A2W tables. I don't recall the usage being super high. But since this particular interface and objects will be new to everyone it's a good time to at least consider changes to how the data is presented and I'm not involved enough on the A2W side to say if the proposed design will be sensible.

It may just be that these new endpoints are only used for the district level control of things and it may not matter, but better to get a conversation started sooner rather than later.

@rma-bryson I would suggest also considering the following scenario to provide a little more insight:

  • 3 dams from different districts
  • at least 3 different elements of data for each.

The current example and test has one, which isn't a good sample size for something that could be rather foundational to our various operations.

@adamscarberry

Copy link
Copy Markdown

@rma-bryson rma-bryson marked this pull request as draft March 6, 2025 18:46
@rma-bryson rma-bryson changed the title CWMVUE-634 Implements Access To Water DTO CWMVUE-634 Implements Access To Water Endpoint Mar 6, 2025
Comment thread cwms-data-api/src/main/java/cwms/cda/data/dto/CwmsId.java
@krowvin

krowvin commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Could help out with
#956

Talked about this on 05/18/26 CDA call.

@krowvin

krowvin commented May 18, 2026

Copy link
Copy Markdown
Collaborator

I do not agree with continuing to name things "accesstowater". Access to water does not name things access to water still (afaik). This goes for endpoint name and class names.

Perhaps this ties into "BEST"? (Sidebar in call With Peter and Eric N about standard naming)

/catalog/{ONESUBNAMETORULETHEMALL/{location-id}/{type}?office=SWT

/catalog/{ONESUBNAMETORULETHEMALL}?location-id=SWT&office=SWT&type=elev

Some sidebar about alias and whether or not "best" is what this should even be called.

Right now not everyone names their TSID version "best"

TBD

@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from c09c6bc to 01dd06f Compare May 20, 2026 21:58
@Enovotny

Enovotny commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

I do not agree with continuing to name things "accesstowater". Access to water does not name things access to water still (afaik). This goes for endpoint name and class names.

Perhaps this ties into "BEST"? (Sidebar in call With Peter and Eric N about standard naming)

/catalog/{ONESUBNAMETORULETHEMALL/{location-id}/{type}?office=SWT

/catalog/{ONESUBNAMETORULETHEMALL}?location-id=SWT&office=SWT&type=elev

Some sidebar about alias and whether or not "best" is what this should even be called.

Right now not everyone names their TSID version "best"

TBD

Some ideas

  1. Best
  2. Authoritative
  3. published
  4. official
  5. reported

@krowvin @MikeNeilson @msweier

I am leaning published....

@MikeNeilson

Copy link
Copy Markdown
Contributor

@krowvin @MikeNeilson @msweier

I am leaning published....

That seems reasonable to me. It is data that is in fact "specifically published" to some place... just happens to be a thing called "Access to Water" at the moment.

@ktarbet

ktarbet commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Also consider:

  • latest
  • current

@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from 4bc02ec to 61cb8f9 Compare June 3, 2026 17:12
@rma-bryson rma-bryson changed the title CWMVUE-634 Implements Access To Water Endpoint CWMVUE-634 Implements Access To Water ("Published") Endpoint Jun 3, 2026
@rma-bryson rma-bryson marked this pull request as ready for review June 3, 2026 17:49
@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch 3 times, most recently from 35a2b5d to e1185f4 Compare June 4, 2026 00:12
/*
* MIT License
*
* Copyright (c) 2025 Hydrologic Engineering Center

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the year.... unless you have a time machine that is.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed — my DeLorean settings were off.

@MikeNeilson MikeNeilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the year in all the files, though ApiServlet is likely fine as is.

@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from be3f20e to 02f7a7c Compare June 8, 2026 21:48
@rma-bryson rma-bryson force-pushed the feature/Adding_Access_To_Water_Endpoint branch from 02f7a7c to c868227 Compare June 8, 2026 21:51
@rma-bryson rma-bryson merged commit b7c4e6e into develop Jun 8, 2026
12 of 13 checks passed
@rma-bryson rma-bryson deleted the feature/Adding_Access_To_Water_Endpoint branch June 8, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants