CWMVUE-634 Implements Access To Water ("Published") Endpoint#1030
Conversation
0670b66 to
1d4ecf3
Compare
There was a problem hiding this comment.
"type" is a bit ambiguous, especially that is is describing the type of parameter (but not to be confused with parameter type inst/ave/const/etc). otherwise the structure looks good. I'd probably prefer parameter even if it doesn't exactly match the parameter in the time series identifier.
41be4ec to
4950f40
Compare
|
I don't hate it, but it's not giving me any warm and fuzzies for the future either. @jeffsuperglide, @adamscarberry can you grant @rma-bryson and @adamkorynta at least read access to the access to water repositories to see how you're using the various A2W tables. I don't recall the usage being super high. But since this particular interface and objects will be new to everyone it's a good time to at least consider changes to how the data is presented and I'm not involved enough on the A2W side to say if the proposed design will be sensible. It may just be that these new endpoints are only used for the district level control of things and it may not matter, but better to get a conversation started sooner rather than later. @rma-bryson I would suggest also considering the following scenario to provide a little more insight:
The current example and test has one, which isn't a good sample size for something that could be rather foundational to our various operations. |
|
@MikeNeilson Invites sent to @rma-bryson and @adamkorynta to join a2w-readonly team. You will find the majority of the sql here: https://github.com/USACE/a2w-api/blob/60558999c32d3ea4c0f477812cb5dc53e77e267f/api/models/locations.go#L83-L358 or here: https://github.com/USACE/a2w-api/blob/develop/api/models/timeseries.go @jeffsuperglide is the POC for the a2w-api |
|
Could help out with Talked about this on 05/18/26 CDA call. |
|
I do not agree with continuing to name things "accesstowater". Access to water does not name things access to water still (afaik). This goes for endpoint name and class names. Perhaps this ties into "BEST"? (Sidebar in call With Peter and Eric N about standard naming)
Some sidebar about alias and whether or not "best" is what this should even be called. Right now not everyone names their TSID version "best" TBD |
c09c6bc to
01dd06f
Compare
Some ideas
@krowvin @MikeNeilson @msweier I am leaning published.... |
That seems reasonable to me. It is data that is in fact "specifically published" to some place... just happens to be a thing called "Access to Water" at the moment. |
|
Also consider:
|
4bc02ec to
61cb8f9
Compare
35a2b5d to
e1185f4
Compare
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2025 Hydrologic Engineering Center |
There was a problem hiding this comment.
You might want to check the year.... unless you have a time machine that is.
There was a problem hiding this comment.
Fixed — my DeLorean settings were off.
MikeNeilson
left a comment
There was a problem hiding this comment.
You might want to check the year in all the files, though ApiServlet is likely fine as is.
be3f20e to
02f7a7c
Compare
02f7a7c to
c868227
Compare
No description provided.