This repository was archived by the owner on Aug 11, 2026. It is now read-only.
fix: apply motion + admin rules to jon.myers.sound@gmail.com account - #893
Merged
Conversation
Four rules were hardcoded to the jbmyers@ucsc.edu user ID
(634d9506a6a3647e543b7641). Extend them to the gmail account
(67bcba9496f2cea9ceb736c2), which is now the primary login.
Motion suppression (motion sensitivity) is consolidated behind a shared
suppressMotion() predicate in src/js/motionPrefs.ts, covering all three
sites that previously compared the raw ObjectId inline:
- EditorComponent: playhead forced to Block on mount
- SpectrogramControls: playhead forced to DottedLine on setting load
- Renderer: wheel/touch scrolling suppressed
AnalyzerComponent's admin gate ("Excel Datasets" analysis type) becomes an
adminIds list rather than a chain of === comparisons.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four rules were hardcoded to the
jbmyers@ucsc.eduuser ID (634d9506a6a3647e543b7641). This extends them tojon.myers.sound@gmail.com(67bcba9496f2cea9ceb736c2), which is now the primary login.Motion suppression (motion sensitivity)
Consolidated behind a shared
suppressMotion()predicate in the newsrc/js/motionPrefs.ts. Three sites previously compared the raw ObjectId inline:EditorComponent.vue— playhead forced toBlockon editor mountSpectrogramControls.vue— playhead forced toDottedLinewhen a display setting loads (overriding the saved setting)Renderer.vue— wheel + touch scrolling suppressed in the rendererNet behavior on the gmail account is now identical to the UCSC account: the playhead never animates, and the renderer does not scroll under wheel/touch.
Admin gate
AnalyzerComponent.vue'sadmincomputed (which unlocks the "Excel Datasets" analysis type) becomes anadminIdslist rather than a chain of===comparisons. Membership:jbmyers@ucsc.edu,jon.myers.sound@gmail.com, Dard Neuman.Notes
Test plan
pnpm build— clean; new ID verified present in both theEditorComponentandAnalyzerComponentchunkspnpm test— 314 tests passed across 16 files🤖 Generated with Claude Code