Sb depthead#131
Closed
sbagg wants to merge 3 commits into
Closed
Conversation
added 3 commits
June 16, 2026 12:32
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “Department Head” status to the separation request details view (Issue #126) so reviewers can see whether the separated employee is/was a department head.
Changes:
- Render a new “Is Department Head” row in the separation details panel.
- Compute department-head status from separation request payload group membership.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/app/client/src/elements/pages/ucdlib-iam-page-separation-single.tpl.js | Displays the new “Is Department Head” field in the Separation Details panel. |
| services/app/client/src/elements/pages/ucdlib-iam-page-separation-single.js | Adds logic to derive department-head status from the request payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+162
to
+167
| getDepartmentHead(){ | ||
| let groups = this.request?.additionalData?.groups || []; | ||
|
|
||
| let deptHead = groups.find(g => {return (g.type === 'Department' && g.partOfOrg)}); | ||
| return deptHead.isHead ? 'Yes' : 'No'; | ||
| } |
| <div><label class='u-inline'>Employee User ID:</label> ${this.employeeUserId}</div> | ||
| <div><label class='u-inline'>Department:</label> ${this.department}</div> | ||
| <div><label class='u-inline'>Separation Date:</label> ${this.separationDate}</div> | ||
| <div><label class='u-inline'>Is Department Head:</label> ${this.departmentHead}</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #126