fix: validate email addresses with MailAddress - #37
Open
PeterKruithof wants to merge 1 commit into
Open
Conversation
Replace weak Contains('@') checks in SetupStep1, SetupStep2, and
ForgotPassword with proper MailAddress validation. Extract shared
IsValidEmail to Application/Utils/ValidationUtils.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PeterKruithof
enabled auto-merge
February 20, 2026 11:49
🧬 Mutation Testing
What does this mean?Stryker mutates your code (flips conditions, removes lines, changes values) and runs tests against each mutation. Killed = tests caught it (good). Survived = tests missed it (weak spot). No Coverage = no test touches this code. Download the full HTML report from the Artifacts section below for per-file details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contains('@')email checks withSystem.Net.Mail.MailAddressvalidation — closes Setup wizard accepts invalid email addresses #18ValidationUtils.IsValidEmail()toJunoBank.Application/Utils/(used in 3 places)SetupStep1.razor,SetupStep2.razor,ForgotPassword.razorTest plan
dotnet build— 0 errorsdotnet test— 160 tests passfoo@,@bar.com,no spaces@test.com) are rejected in setup wizard and forgot password🤖 Generated with Claude Code