Skip to content

Fix email config always showing not configured - #12

Merged
Tzeetzch merged 1 commit into
masterfrom
fix/email-config-path
Feb 17, 2026
Merged

Fix email config always showing not configured#12
Tzeetzch merged 1 commit into
masterfrom
fix/email-config-path

Conversation

@PeterKruithof

Copy link
Copy Markdown
Collaborator

Summary

  • Fix path mismatch that caused email settings to always show "Not configured" on Docker/Linux
  • Add UI refresh after email settings dialog closes

Root cause

Program.cs hardcoded the email config path as Data/email-config.json, while EmailConfigService derived it from the connection string. On Docker, the connection string is Data Source=/app/data/junobank.db, so the service wrote to /app/data/email-config.json — a different path on case-sensitive Linux.

Fix

Derive the path from the connection string in both places (2-line change in Program.cs).

Test plan

  • 154 unit tests pass
  • CI passes
  • Deploy to Docker, configure email via settings dialog, verify it shows "SMTP configured"

Closes #9

🤖 Generated with Claude Code

…vice

Program.cs hardcoded `Path.Combine("Data", "email-config.json")` while
EmailConfigService derived the path from the connection string. On Docker
(connection string = `Data Source=/app/data/junobank.db`), the service
wrote to `/app/data/email-config.json` but the app read from
`Data/email-config.json` — different paths on case-sensitive Linux.

Fix: derive both paths from the connection string.

Also adds StateHasChanged() after email dialog closes so the UI
refreshes to show the updated configuration status.

Closes #9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧬 Mutation Testing

Metric Value
Score 47.95% ➡️ (0.00% vs baseline)
Killed 337
Survived 134
No Coverage 234
Timeout 2
What does this mean?

Stryker mutates your code (flips conditions, removes lines, changes values) and runs tests against each mutation. Killed = tests caught it (good). Survived = tests missed it (weak spot). No Coverage = no test touches this code.

Download the full HTML report from the Artifacts section below for per-file details.

@Tzeetzch
Tzeetzch merged commit c120873 into master Feb 17, 2026
2 checks passed
@Tzeetzch
Tzeetzch deleted the fix/email-config-path branch February 17, 2026 14:58
@PeterKruithof
PeterKruithof restored the fix/email-config-path branch February 19, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email settings shows 'Not configured' after saving

2 participants