🛡️ Sentinel: [HIGH] Fix PII leak in Sentry Feedback#236
🛡️ Sentinel: [HIGH] Fix PII leak in Sentry Feedback#236google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: HIGH
💡 Vulnerability: When submitting feedback, the user email is temporarily set in the global Sentry SDK. If the submission throws an error, the cleanup code is never reached, leaking the PII to all subsequent crash reports.
🎯 Impact: User email addresses could be inadvertently leaked and associated with unrelated app crashes or errors.
🔧 Fix: Wrapped the Sentry SDK user cleanup in a defer block to guarantee execution.
✅ Verification: Code review confirms defer is used.
PR created automatically by Jules for task 13253342652013416492 started by @TytaniumDev