π‘οΈ Sentinel: [HIGH] Fix PII leak in Sentry error reporting#233
π‘οΈ Sentinel: [HIGH] Fix PII leak in Sentry error reporting#233google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: User email (PII) is temporarily added to the global Sentry scope during feedback submission but is not cleared if the submission throws an error.
π― Impact: If feedback submission fails, the user's email remains attached to all subsequent events and crash reports for the remainder of the application session, violating data privacy.
π§ Fix: Used a
deferblock to guaranteeSentrySDK.setUser(nil)is called when exiting the submission scope, even when an error is thrown.β Verification: Tested locally by verifying format and linting.
PR created automatically by Jules for task 3693071692385967085 started by @TytaniumDev