Skip to content

Rebuild law firm security review page#80

Merged
SeoFood merged 2 commits into
mainfrom
seofood/legal-security-review-redesign
May 26, 2026
Merged

Rebuild law firm security review page#80
SeoFood merged 2 commits into
mainfrom
seofood/legal-security-review-redesign

Conversation

@SeoFood
Copy link
Copy Markdown
Contributor

@SeoFood SeoFood commented May 26, 2026

Summary

  • Rebuild /business/legal-security-review with Legal-vertical React sections (hero, checklist, data flow, boundaries, related links, CTA)
  • Move page copy into locale MDX files with a dedicated loader (src/data/legal-security-review.ts)
  • Add UI chrome labels under business.legalSecurityReview.* in business.json
  • Migrate privacy page copy to privacy.json (de/en) with dynamic localePath link to the security review page
  • Add cross-links from law-firm dictation and legal use-case pages (de/en)

Test plan

  • npm run build passes (238 pages, i18n 892 keys)
  • Verify /de/business/legal-security-review and /en/business/legal-security-review render all sections
  • Confirm privacy security-review link uses locale-aware URL
  • Confirm business trust CTA and use-case cross-links reach the page

Summary by CodeRabbit

  • New Features

    • Added a dedicated legal & security review section with hero, checklist, data-flow, boundaries, related links, and CTA components.
    • Integrated mailto and navigation CTAs for business inquiries.
  • Refactor

    • Converted the review page to a data-driven, component-based rendering approach.
  • Localization

    • Added German and English privacy content and business translations.
  • Documentation

    • Linked the public security-review checklist from law-firm use-case pages.

Review Change Stack

Move page copy into locale MDX, add Legal-vertical React components, migrate privacy to i18n JSON, and link the page from legal use cases.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bfd1979-2bd8-4728-991f-c289de7f8d3f

📥 Commits

Reviewing files that changed from the base of the PR and between 13764e9 and 5736126.

📒 Files selected for processing (2)
  • src/i18n/locales/de/privacy.json
  • src/i18n/locales/en/privacy.json
✅ Files skipped from review due to trivial changes (1)
  • src/i18n/locales/de/privacy.json

📝 Walkthrough

Walkthrough

This PR introduces a complete legal-security-review feature for law firms, including a data-driven content schema, six reusable React section components, bilingual (English/German) localized content and i18n translations, and refactored Astro pages that render the new feature while also updating the privacy page to use i18n helpers instead of hardcoded copy.

Changes

Legal Security Review Feature

Layer / File(s) Summary
Data schema and content loader
src/data/legal-security-review.ts
LegalSecurityReviewContent and LegalSecurityReviewModule types define the structure for hero, checklist, data flow, boundaries, related links, and CTA sections; getLegalSecurityReviewModule(locale) loads the matching locale's MDX module and throws if missing.
Reusable section components
src/components/business/legal-security-review/legal-security-review-hero.tsx, legal-security-review-checklist.tsx, legal-security-review-data-flow.tsx, legal-security-review-boundaries.tsx, legal-security-review-related.tsx, legal-security-review-cta.tsx
Six React components render distinct sections: hero (with gradient, CTA, back link), checklist (numbered items), data-flow grid, boundaries list, related links, and CTA section; each applies color-driven styling and accepts locale for localized labels.
i18n translations for business and privacy
src/i18n/locales/en/business.json, src/i18n/locales/de/business.json, src/i18n/locales/en/privacy.json, src/i18n/locales/de/privacy.json, src/i18n/locales/en/index.ts, src/i18n/locales/de/index.ts
New business.legalSecurityReview.* keys added for hero CTAs, back link, and checklist label; new privacy.* namespace covers privacy policy sections including localStorage, network access, security review link, and open-source info; both en/de locale indices integrate privacy.json.
MDX content pages (English and German)
src/content/business/en/legal-security-review.mdx, src/content/business/de/legal-security-review.mdx
Structured frontmatter (title, description, color, hero text) and sections (checklist items, data-flow breakdown, deliberate boundaries, related links, CTA) define the content consumed by section components.
Astro page refactoring and privacy page i18n
src/pages/[locale]/business/legal-security-review.astro, src/pages/[locale]/privacy.astro
legal-security-review.astro switched from inline hardcoded copy to data-driven rendering using module loader and section components; privacy.astro refactored from bilingual static object to i18n-driven section model with conditional rendering for text, localStorage list, and security-review link.
Use-case page references
src/content/use-cases/en/law-firm-dictation.mdx, src/content/use-cases/de/law-firm-dictation.mdx, src/content/use-cases/en/legal.mdx, src/content/use-cases/de/legal.mdx
Added callout links pointing to the security-review checklist for IT and privacy review before rollout on both language versions of law-firm-dictation and legal use-case pages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • TypeWhisper/typewhisper.com#79: Implements the initial /[locale]/business/legal-security-review Astro page; this PR refactors that same page from inline content to a data-driven module + component architecture.

Poem

🐰 A review so clear, for firms who care,
Security and data, stored with flair,
Components reuse, translations abound,
Privacy policies, properly found,
Local and safe, TypeWhisper's path bright!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: rebuilding the law firm security review page with new component-based architecture and MDX-driven content.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch seofood/legal-security-review-redesign

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/i18n/locales/de/privacy.json`:
- Around line 7-17: The privacy copy uses absolute statements like in
"privacy.section.dataCollection.p1" and "privacy.section.network.p1" claiming
data is "never" sent to any server, which conflicts with optional cloud/custom
endpoints in business.json; update those keys to qualify that TypeWhisper
processes data locally by default and only sends data to external services when
the user explicitly opts into cloud or custom endpoints (mention explicit opt-in
and examples such as downloading models from Hugging Face or configured cloud
endpoints), and adjust related keys like "privacy.section.overview.p1" and
"privacy.section.localStorage.p2" to reflect default-local behavior plus the
opt-in exception.

In `@src/i18n/locales/en/privacy.json`:
- Around line 7-17: Update the privacy copy to qualify “local / no server”
statements as “local by default” and mention explicit opt-in exceptions for
cloud or custom endpoints: change the strings under
privacy.section.dataCollection.p1, privacy.section.overview.p1, and
privacy.section.network.p1 to state that processing and storage occur locally by
default but users may opt into cloud services or configure custom endpoints
(e.g., model downloads or analytics) and that those behaviors require explicit
user consent or configuration; keep the local storage and offline functionality
language but add a short qualifier about optional cloud features and opt-in.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 29c33318-ed86-45a0-97e1-1d1178bab1cc

📥 Commits

Reviewing files that changed from the base of the PR and between 21f3526 and 13764e9.

📒 Files selected for processing (21)
  • src/components/business/legal-security-review/legal-security-review-boundaries.tsx
  • src/components/business/legal-security-review/legal-security-review-checklist.tsx
  • src/components/business/legal-security-review/legal-security-review-cta.tsx
  • src/components/business/legal-security-review/legal-security-review-data-flow.tsx
  • src/components/business/legal-security-review/legal-security-review-hero.tsx
  • src/components/business/legal-security-review/legal-security-review-related.tsx
  • src/content/business/de/legal-security-review.mdx
  • src/content/business/en/legal-security-review.mdx
  • src/content/use-cases/de/law-firm-dictation.mdx
  • src/content/use-cases/de/legal.mdx
  • src/content/use-cases/en/law-firm-dictation.mdx
  • src/content/use-cases/en/legal.mdx
  • src/data/legal-security-review.ts
  • src/i18n/locales/de/business.json
  • src/i18n/locales/de/index.ts
  • src/i18n/locales/de/privacy.json
  • src/i18n/locales/en/business.json
  • src/i18n/locales/en/index.ts
  • src/i18n/locales/en/privacy.json
  • src/pages/[locale]/business/legal-security-review.astro
  • src/pages/[locale]/privacy.astro

Comment thread src/i18n/locales/de/privacy.json Outdated
Comment thread src/i18n/locales/en/privacy.json Outdated
@SeoFood SeoFood merged commit ec9facc into main May 26, 2026
1 check passed
@SeoFood SeoFood deleted the seofood/legal-security-review-redesign branch May 26, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant