Rebuild law firm security review page#80
Conversation
Move page copy into locale MDX, add Legal-vertical React components, migrate privacy to i18n JSON, and link the page from legal use cases. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR introduces a complete legal-security-review feature for law firms, including a data-driven content schema, six reusable React section components, bilingual (English/German) localized content and i18n translations, and refactored Astro pages that render the new feature while also updating the privacy page to use i18n helpers instead of hardcoded copy. ChangesLegal Security Review Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/locales/de/privacy.json`:
- Around line 7-17: The privacy copy uses absolute statements like in
"privacy.section.dataCollection.p1" and "privacy.section.network.p1" claiming
data is "never" sent to any server, which conflicts with optional cloud/custom
endpoints in business.json; update those keys to qualify that TypeWhisper
processes data locally by default and only sends data to external services when
the user explicitly opts into cloud or custom endpoints (mention explicit opt-in
and examples such as downloading models from Hugging Face or configured cloud
endpoints), and adjust related keys like "privacy.section.overview.p1" and
"privacy.section.localStorage.p2" to reflect default-local behavior plus the
opt-in exception.
In `@src/i18n/locales/en/privacy.json`:
- Around line 7-17: Update the privacy copy to qualify “local / no server”
statements as “local by default” and mention explicit opt-in exceptions for
cloud or custom endpoints: change the strings under
privacy.section.dataCollection.p1, privacy.section.overview.p1, and
privacy.section.network.p1 to state that processing and storage occur locally by
default but users may opt into cloud services or configure custom endpoints
(e.g., model downloads or analytics) and that those behaviors require explicit
user consent or configuration; keep the local storage and offline functionality
language but add a short qualifier about optional cloud features and opt-in.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 29c33318-ed86-45a0-97e1-1d1178bab1cc
📒 Files selected for processing (21)
src/components/business/legal-security-review/legal-security-review-boundaries.tsxsrc/components/business/legal-security-review/legal-security-review-checklist.tsxsrc/components/business/legal-security-review/legal-security-review-cta.tsxsrc/components/business/legal-security-review/legal-security-review-data-flow.tsxsrc/components/business/legal-security-review/legal-security-review-hero.tsxsrc/components/business/legal-security-review/legal-security-review-related.tsxsrc/content/business/de/legal-security-review.mdxsrc/content/business/en/legal-security-review.mdxsrc/content/use-cases/de/law-firm-dictation.mdxsrc/content/use-cases/de/legal.mdxsrc/content/use-cases/en/law-firm-dictation.mdxsrc/content/use-cases/en/legal.mdxsrc/data/legal-security-review.tssrc/i18n/locales/de/business.jsonsrc/i18n/locales/de/index.tssrc/i18n/locales/de/privacy.jsonsrc/i18n/locales/en/business.jsonsrc/i18n/locales/en/index.tssrc/i18n/locales/en/privacy.jsonsrc/pages/[locale]/business/legal-security-review.astrosrc/pages/[locale]/privacy.astro
Summary
/business/legal-security-reviewwith Legal-vertical React sections (hero, checklist, data flow, boundaries, related links, CTA)src/data/legal-security-review.ts)business.legalSecurityReview.*inbusiness.jsonprivacy.json(de/en) with dynamiclocalePathlink to the security review pageTest plan
npm run buildpasses (238 pages, i18n 892 keys)/de/business/legal-security-reviewand/en/business/legal-security-reviewrender all sectionsSummary by CodeRabbit
New Features
Refactor
Localization
Documentation