Run cargo +nightly fmt --all and fix CI job#76
Open
SwishSwushPow wants to merge 1 commit into
Open
Conversation
SwishSwushPow
force-pushed
the
cargo_fmt_all
branch
2 times, most recently
from
f371616 to
8ddb469
Compare
Additionally adjust the CI job and fix some typos
SwishSwushPow
force-pushed
the
cargo_fmt_all
branch
from
8ddb469 to
06f0f01
Compare
Author
|
Sorry for the pushes, my changes to the CI job were not correct. 😅 I moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋
While working with
tobjI noticed that I have to runcargo fmtwith the nightly toolchain for it to work correctly. That led me to having a look into the CI and I noticed that the fmt step is not applying all the rules either (e.g. here if you check the fmt step: https://github.com/Twinklebear/tobj/actions/runs/27104693119/job/79991600178).So I wanted to fix the job and also apply all the fmt rules with this PR.
I have also taken this chance to fix a couple of random typos.
My IDE also auto-formats parts of the README.md but I have not included it yet because I'm not sure if that is a welcome change. If it is just let me know and I can update this PR.
Edit: Whoops sorry I accidentally pushed a commit from another branch. I've force pushed again to fix that.