fix: Validate twingate.host against trusted controller domains#353
Closed
minhtule wants to merge 4 commits into
Closed
fix: Validate twingate.host against trusted controller domains#353minhtule wants to merge 4 commits into
twingate.host against trusted controller domains#353minhtule wants to merge 4 commits into
Conversation
minhtule
changed the title
twingate.host against trusted controller domains
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 86.07% 86.37% +0.29%
==========================================
Files 40 40
Lines 2830 2847 +17
==========================================
+ Hits 2436 2459 +23
+ Misses 269 264 -5
+ Partials 125 124 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens configuration security by validating twingate.host during config validation to ensure the controller JWKS trust anchor can only point at approved Twingate-owned domains.
Changes:
- Add
twingate.hosthostname validation and restrict it to trusted suffixes (twingate.com,opstg.com,test). - Extend
Config.Validate()to enforce the new host validation. - Add/adjust config validation tests to cover allowed and disallowed host values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/config/config.go | Adds host validation logic (regex + trusted suffix allowlist) and enforces it during config validation. |
| internal/config/config_test.go | Updates existing validation tests and adds new cases for allowed/disallowed twingate.host values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+708
to
+712
| for domain := range IssuerByDomain { | ||
| if lowered == domain || strings.HasSuffix(lowered, "."+domain) { | ||
| return nil | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
.test is RFC 6761 non-routable/local-only. We don't need custom code for it.
Comment on lines
+23
to
27
| for domain, issuer := range config.IssuerByDomain { | ||
| if lowered == domain || strings.HasSuffix(lowered, "."+domain) { | ||
| return issuer | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
.test is RFC 6761 non-routable/local-only. We don't need custom code for it.
| "test": "twingate-local", | ||
| "dev.opstg.com": "twingate-dev", | ||
| "stg.opstg.com": "twingate-stg", | ||
| "sec.opstg.com": "twingate-sec", |
Comment on lines
+361
to
+365
| { | ||
| name: "host with test suffix", | ||
| config: &Config{ | ||
| Twingate: TwingateConfig{Network: "test", Host: "acme.test"}, | ||
| Port: 8443, |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Tickets & Documents
Changes
twingate.networkis a single DNS label, since it is interpolated into the JWKS URL authority.twingate.hostagainst the trusted Twingate controller domains, matched case-insensitively, using the same allowlist as token issuer validation (single source of truth inconfig) so an accepted host always has a known JWT issuer.