Skip to content

chore: Improve SSH unit tests#345

Draft
minhtule wants to merge 11 commits into
masterfrom
feat/mt/improve-ssh-unit-test
Draft

chore: Improve SSH unit tests#345
minhtule wants to merge 11 commits into
masterfrom
feat/mt/improve-ssh-unit-test

Conversation

@minhtule

Copy link
Copy Markdown
Contributor

Changes

TBD

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (ae1a656) to head (5fcf05c).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   86.07%   88.39%   +2.31%     
==========================================
  Files          40       39       -1     
  Lines        2830     2637     -193     
==========================================
- Hits         2436     2331     -105     
+ Misses        269      199      -70     
+ Partials      125      107      -18     
Flag Coverage Δ
integration 57.36% <69.56%> (+2.50%) ⬆️
unit 81.91% <100.00%> (+3.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/sshhandler/channel_pair.go 95.95% <100.00%> (+4.04%) ⬆️
internal/sshhandler/conn_pair.go 100.00% <100.00%> (+19.04%) ⬆️
internal/sshhandler/proxy.go 92.07% <100.00%> (+12.25%) ⬆️
internal/sshhandler/request_handler.go 87.77% <100.00%> (+6.82%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

minhtule added 6 commits June 28, 2026 10:01
- forward denied-from-upstream global requests sent by downstream
- CloseWrite/Close propagation during channel teardown
- accept loop handling of generic (non-ErrClosed) listener errors
- drop the nil-conn guard only the old mock listener could trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant