Replace Turing.PROGRESS with AbstractMCMC.PROGRESS - #2851
Open
hardikxk wants to merge 7 commits into
Open
Conversation
Updated the sampler and variational defaults, tests, api doc, and added a history entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
- Coverage 85.09% 85.04% -0.05%
==========================================
Files 23 23
Lines 1516 1511 -5
==========================================
- Hits 1290 1285 -5
Misses 226 226 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Not sure why the formatter is still red :( |
Member
|
Run formatter on |
shravanngoswamii
self-requested a review
July 19, 2026 11:37
Contributor
Author
|
Thanks it was one whitespace causing the issue! |
shravanngoswamii
left a comment
shravanngoswamii
left a comment
Member
There was a problem hiding this comment.
I think this should not become the breaking change for users. It should be internal implementation detail. @sunxd3 Any thoughts?
Member
@hardikxk let's change the direction of PR to non-breaking changes |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch removes
Turing.PROGRESSandTuring.setprogress!in favor ofAbstractMCMC.PROGRESSandAbstractMCMC.setprogress!.Updated the sampler and variational defaults, tests, api doc, and added a
history entry.