Use step_warmup for AdaptiveHamiltonian - #2683
Closed
penelopeysm wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Oh, for goodness' sake, this is way more annoying than I had realised. |
penelopeysm
marked this pull request as draft
October 7, 2025 12:50
Contributor
Author
|
I think this will just have to wait for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2678
Note, CI not running because this needs TuringLang/AbstractMCMC.jl#178 to go through.
This PR:
nadaptsargument from HMCDA and NUTS constructors. Instead of specifying that, the user should specify thenum_warmupkeyword argument tosample().discard_adaptkeyword argument when sampling with HMCDA/NUTS, in favour ofdiscard_initial, which has the same meaning for all samplers and is therefore more coherent.AbstractMCMC.step_warmupfor these samplers.This also needs: