Port TuringCallbacks to AbstractMCMC - #187
Conversation
|
AbstractMCMC.jl documentation for PR #187 is available at: |
yebai
left a comment
yebai
left a comment
There was a problem hiding this comment.
Thanks @shravanngoswamii -- let's refactor a bit further to export a single symbol mcmc_callback instead.
|
@yebai Let me know if you have further suggestions or changes! |
yebai
left a comment
yebai
left a comment
There was a problem hiding this comment.
It's getting there -- a few more refactoring comments!
…from TBL ext and others
|
Added stats=true / stats=:default shorthand for requesting default statistics. Only |
yebai
left a comment
yebai
left a comment
There was a problem hiding this comment.
Excellent work -- I'm fully happy with this!
@penelopeysm can you also take a look?
|
@shravanngoswamii I realise that some of these design choices I'm commenting on might not be yours, but now is as good a time as any to clean them up! |
Moved OnlineStats Wrappers section to a new location in the document and updated formatting.
I did not make any new design choices other than suggested, so it's mostly all old |
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
|
@shravanngoswamii @penelopeysm please feel free to make a new release. |
|
This PR will deprecate TuringCallbacks.jl