Match GPU NMF denominator handling to sklearn - #8
Merged
OlivierBakker merged 1 commit intoJul 28, 2026
Conversation
JerryIshihara
force-pushed
the
fix/sklearn-nmf-zero-guard
branch
from
July 27, 2026 17:32
72a73a3 to
e1e3fc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation added
epsto every denominator:scikit-learn only replaces denominators that are exactly zero. Adding
epsto valid, nonzero FP64 denominators slightly changed every update, while the same1e-9addition generally rounded away in FP32.The update now leaves nonzero denominators untouched and replaces only exact zeros:
The same change is applied to the
Hupdate and the fixed-Hpath, and the default replacement value now matches scikit-learn's FP32 epsilon.