test(frontend): continue mobile and storefront verification - #3
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The e2e/ Playwright harness is deliberately isolated with its own package.json, so @playwright/test is not installed at the repo root. Next production builds type-check every .ts file the root tsconfig includes, so e2e/playwright.config.ts failed to resolve @playwright/test and broke every Vercel deployment of this branch since 76788e4. Excluding e2e/**/* matches the existing FRONTEND/**/* exclusion; the harness type-checks against its own node_modules instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This continues from the first genuinely unfinished item documented in the existing PDP handoff: automated mobile, route, accessibility and visual-state verification.
e2e/Preserved scope
No backend contracts, authentication, cart, checkout, payment, inventory or product-data logic were replaced. The perfume-only direction remains intact. No perfume, ingredient, accord, review, stock or performance data was invented.
Why
The previous implementation recorded manual mobile and accessibility QA but explicitly listed the missing Playwright and axe harness as the top remaining engineering requirement. This PR starts there rather than repeating completed redesign work.
Validation status
The new suite has not been claimed as passing yet. It is intentionally opened as a draft so CI can run against the current deployment and expose real route, mobile, accessibility and visible-copy regressions before merge. A preview deployment can be targeted with
E2E_BASE_URLfor branch-specific verification.