Conversation
danmcd
reviewed
Apr 24, 2025
danmcd
left a comment
danmcd
left a comment
Contributor
There was a problem hiding this comment.
Will changing the Rust toolchain require a minimum PI bump? Oh, and do we need to enforce a minimum PI?
|
|
||
| NAME = smartos-ui | ||
| RUST_TOOLCHAIN = 1.75.0 | ||
| RUST_TOOLCHAIN = 1.84.1 |
Contributor
There was a problem hiding this comment.
Does this bump the minimum PI that SmartOS UI needs?
Contributor
There was a problem hiding this comment.
Oooh, I see the code to check for that is commented out, and dependent on manta...
# # Get the minimium supported PI from the Manta object's metadata
# minimium_pi=$("${CURL[@]}" -I -o /dev/null -w '%header{m-minimum-pi}' \
# "${URL_PREFIX}/smartos-ui-$version.tar.gz")
# if [[ "${Live_Image:?}" < "$minimium_pi" ]]; then
# err "$version requires a platform image of $minimium_pi or newer"
# fi
That starts at line 181 of uiadm.sh.
nshalman
force-pushed
the
OS-8535
branch
4 times, most recently
from
b62ef2b to
c45d246
Compare
danmcd
reviewed
May 2, 2025
| RUST_TOOLCHAIN = 1.84.1 | ||
|
|
||
| ENGBLD_USE_BUILDIMAGE = false | ||
| ENGBLD_SKIP_VALIDATE_BUILDENV = true |
Contributor
There was a problem hiding this comment.
Will we need that with the recent push to eng?
| export STAMP | ||
|
|
||
| BUILD_PLATFORM = 20210826T002459Z | ||
| BUILD_PLATFORM := 20240111T002438Z |
Contributor
There was a problem hiding this comment.
That happens to be the PI of where the one zone landed. Did you pick that for that specific reason? Or is there another?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to wire up the SmartOS installer to be able to install smartos-ui at setup time, it will need some improvements.
This PR is where I will build those.
First some tidying before I get to the heart of that.