TDF Contraband Permit Console - #454
Open
TheRealMasterChief117 wants to merge 31 commits into
Open
Conversation
…or granting and revoking, add TDF permit management access Next commit will be permit persistence with ships
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Collaborator
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



About the PR
Adds the contraband permit manager, the long awaited feature that allows for persistent permits and an easy way to manage them for TDF, increasing merc-TDF interaction!
You print out a chip from the console, which allows you to scan a valid permittable contraband item. Then, the permit owner scans their identity on the card by interacting with it. From there, you insert it into the console, go into the grant permit tab. (Only the Chief Enforcer can grant permits!) and enter in a valid reason. then press the grant button.
It also allows you to revoke permits remotely. When a permit is granted or revoked, the permit owner will receive a PDA message.
Extra
Should be mapped to Auric in reception, briefing, and the CE's office
SOP entry should be added too
Do extensive testoing
Media
How to test
Print a chip, spawn in an entity with contraband permittable (auth disruptor or something), scan it, then scan your player. Give your character the
ContrabandPermitGranterComponentso they can grant in permits. You need PTL access or above to revoke permits.Test if it works with ship saving for things that delete (TDF gear)
Technical details
Added the HumanoidViewer system, which spawns in a clone of the player's character in a paused map, for things like photographs. The console system uses it to get a picture of the player's character without being a live feed of their sprite. This view is also globally PVS, so clients can see the appearance of the view mobs at ALL times. Checks are in place so that this viewer mob is not recreated when a player respawns with the same character.
Items with valid permits also have global PVS, so that you can view them on the console. I am unsure on how performant/correct this implementation of networking the console this way, however. Would like some extra eyes on that.
Requirements
Changelog
🆑