Port: Frontier's Expedition System Rework - #443
Draft
Wuffindy wants to merge 14 commits into
Draft
Conversation
This reverts commit 56551ce. un mono exped 1
This reverts commit d707d55. revert mono's weather system
* Expo Dework For Rework * Upstream stuff * multiple difficulties, failure timeouts * big wip, comment 33105 cherry-picks * SalvageExpeditions: early finish, mission params * restore more params * random expedition types * compilation fixes, copy OfferingWindow layout * More salvage job jank * expedition/destruction logic, move missions to _NF * early finish handler * lingering FTL * cooldown when in FTL * build errors * Frontier-specific salvage loot * optional loot tables per difficulty * Cleanup * Update SalvageSystem.ExpeditionConsole.cs * Update salvage_factions.yml * Update salvage_factions.yml * mob costs update * order missions by difficulty (scuffed) * Update salvage-faction.ftl * more fiddling with costs * loc strings * expedition map wrangling * frontier comments, empty array safety * return structures/enemies to salvage missions * structure count per difficulty level * asteroid.id is fine * Fix timer bar * "expedition console", objective announcement * Remove difficulty and rewards from expedition comp * salvage system: fix timeout announcements * Remove unneeded grid params, use obj-scoped mapUid * Loot test * Update loot tables test * Update salvage_loot.yml * Make the contravend more of a goal then random syndicate stuff * salvage expeditions: weights and difficulties * debug params, yeet ghosts * using the wrong entity on expedition finish * entity/structure spawning, admin ghost extraction * Increase glider cost to 2 --------- Co-authored-by: Whatstone <whatston3@gmail.com> Co-authored-by: steinhauer.erhard <steinhauer.erhard@gmail.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
* DoMapInitialize and SetMapPaused * GridTileToLocal * Formatting * Remove unused variables * Update Content.Server/Salvage/SpawnSalvageMissionJob.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
github-actions
Bot
added
S: Untriaged
size/L
C#
YML
FTL
Collaborator
|
Gem, speedmerging this |
Collaborator
Author
if i remove the reward, can be speedmerged ironically, but not yet |
…asier access to rewards (unadjuste variable type yet)
|
I'm down to have expeds be great again |
Wuffindy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
updates Triad's expedition to frontier's newer or well closer to upstream's version, most of these are for easier implemetation of future contents, and a step closer to themed expedition
new-frontiers-14/frontier-station-14#3046
drafting this for now while awaiting the coyot exped retrieval and some guidance on some c# stuff
to do:
Understanding of how frontier's code work depends on whether there's difficulty in the faction proto, otherwise it ignores it and is eligible for all difficulty
Why / Balance
current ones outdated, this should get us up closer and easier for future content
Media
Requirements
How to test
buy shipwith exp console, claim, finish expeditions, claim, finish expedition, etc
Breaking changes
needs intensive testing on running expeditions multiple times, previously no error, but still lacking rewards and removed weather from this
Changelog
non player facing