Port Starlight Clothing and Add to Loadout (Branch Name Change) - #334
Port Starlight Clothing and Add to Loadout (Branch Name Change)#334pandoraberry wants to merge 31 commits into
Conversation
|
RSI Diff Bot; head commit 296ae35 merging into ec7d1b0 Resources/Textures/Clothing/Uniforms/Jumpsuit/rainbow.rsi
Resources/Textures/_Starlight/Clothing/Head/Hats/belpero.rsi
Resources/Textures/_Starlight/Clothing/Head/Hats/red_regalia.rsi
Resources/Textures/_Starlight/Clothing/Neck/Cloaks/ari.rsi
Resources/Textures/_Starlight/Clothing/Neck/Cloaks/belpero.rsi
Resources/Textures/_Starlight/Clothing/Neck/Cloaks/red_regalia.rsi
Resources/Textures/_Starlight/Clothing/Neck/Cloaks/shuba.rsi
Resources/Textures/_Starlight/Clothing/Shoes/Boots/ari.rsi
Resources/Textures/_Starlight/Clothing/Shoes/Boots/belpero.rsi
Resources/Textures/_Starlight/Clothing/Shoes/Boots/highheelshoes.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/alt_purplebartender.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/cap_turtleneck.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/cargoformal.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/centcom_officer.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/centcom_official.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/clown_distinguished.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/coroner.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_gothic.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_maid.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_red.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_tango.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_victorian_black.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/dress_victorian_red.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/elegantmaid.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/hop_turtleneck.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/hos_black.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/journalist.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/lady.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/mining.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pastry.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_centcom_official.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_special_operations_officer.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/pencil_tan.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/performer_clown.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/performer_mime.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/rainbow.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/rd_classical.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/reporter.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvage.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvageformal.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/salvagelead.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/schoolskirt.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/scientist_formal.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpskirt/suit_nurse.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/ari.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/belpero.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/cap_turtleneck.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/captainnoble.rsi
Resources/Textures/_Starlight/Clothing/Uniforms/Jumpsuit/cargo.rsi
|
mnva0
left a comment
There was a problem hiding this comment.
Okay, little review. Thank you for this PR! I tested 100/493 files on multiple different species, including monkeys and all their directional sprites. Sorry about not reviewing that much in one go; something came up and I urgently need to hyperfocus on that.
Unlike my other large reviews, my review notes are not currently in a publishable state. I do not have the time to clean them up. I'll do that when I have time
You may want to remove the space after the X so GitHub formats your checkboxes. Like this
- a
Also, the changelog is for the players to read, not entirely for us. See the #changelog channel (where these get published) on the Discord for examples. Please write a (brief! can't include everything) player-facing summary of what's been added
You should have also likely included your testing media higher up. I don't know how the changelog bot will behave with the images at the bottom instead of the media section
…si/equipped-HELMET-cyclorite.png -deleted cyclorite png
…si/equipped-HELMET-felionoid.png
….rsi/equipped-NECK-cyclorite.png
….rsi/equipped-NECK-felionoid.png
fixing typo
Removed Felinoid and Cyclorite from meta.json
There was a problem hiding this comment.
Thank you for making some changes! I read a couple more files. We're not supposed to use other SS14 servers' namespaces like this I think? Starlight likely did not make most of these changes, they were compatibility additions made for the Triad server
I booted up my developer environment to review more files, but was stopped by this fatal error. I'm not sure if the client I'm using is just making things up or something. It's probably something to do with meta.json somewhere
[FATL] unhandled: System.Collections.Generic.KeyNotFoundException: The given key 'equipped-HELMET-cyclorite' was not present in the dictionary.
Removed empty comment
Removed unused equipped-HELMET entries from meta.json.
|
Do keep anything adding grouping separate from this PR. You can always update this one after that's merged. But this would be erroring and not launching if I'll DM you my notes |
|
Fixed typos and reworded a bunch of descriptions. As for the spriting, and inhand sprite issues, I'll have to take a closer look later. I think it's a matter of missing sprites for some. I realized that the 'UniformBootsVampir' thing is because that's the naming convention of the whole 'Vampir' Set, so was hesitant to change. Didn't change the weird numbered ID's yet. As for the displacement issues...I'll look for fixes. If any other spritainer wants to take a look at those, please do. |
mnva0
left a comment
There was a problem hiding this comment.
I have finally reviewed all 487 files by hand. I'd like to get reviews from other maintainers here and I will be forwarding the list of random issues I found to our private channel. Thank you for putting up with this
We might want to ditch the "_Triad/Loadouts/Imported/Starlight" directory in favor of cleaner loadout entries directly under _Triad/Loadouts? A lot of these should've already been in the loadout to begin with, and updating these so they aren't arbitrarily marked as WF would break loadouts when we do it later I think. In addition, I think there's a bunch of overlap
The "tiers" mentioned in the loadout entries (seemingly only in comments?) are also very legacy I believe
|
Ooooh~! Love the Starlight clothing, thank you so much for PRing this <3 |
771169a to
a085811
Compare
|
Push is because I fucked up somewhere with the ID renaming. Gonna look at this tomorrow with fresh eyes. |
Corrected the capitalization of 'hat' in the name field.
|
More on the updates here As for the displacement issues, they seem incredibly widespread and there is no current PR's on Starlight or other branches addressing them. I will be creating a separate PR to address those. Incomplete, but I did fix the Salvage Lead's issues with most species except Resomi. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
So, I changed my mind on separating. I think having it all in one works because it's addressing all the rendering issues for the species brought up. I've merged when I have so far here which is new inhand sprites, the skirtDisplacement component, Avali fixes and a test of the Hydrakin sprite. |
Removed unnecessary text from summary comment for skirt-specific displacement.

























































































































































































About the PR
Ports the Starlight clothing pack from Wayfarer and integrates it into Triad's loadout system.
This includes importing the clothing loadouts, organizing them into Triad's existing loadout groups, and cleaning up invalid or duplicate entries encountered during the port.
Why / Balance
Expands player customization by adding a large selection of cosmetic clothing options. This PR does not significantly affect gameplay balance.
Media
Requirements
How to test
Breaking changes
None.
Changelog
🆑