fix(triggers): scope editor fields to selected event - #200
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 3 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change prevents duplicate trigger inputs by applying selected-trigger conditions consistently. It adds the Webflow form submission trigger and scopes its configuration fields. Tests cover trigger field uniqueness and Webflow field visibility. ChangesTrigger visibility
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change limits trigger editor fields to the selected event and adds Webflow form submission support without changing schemas, APIs, or provider behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
| Filename | Overview |
|---|---|
| apps/tradinggoose/triggers/index.ts | Generated trigger shell fields now consistently inherit the selected-trigger condition. |
| apps/tradinggoose/triggers/webflow/collection_item_created.ts | Adds Webflow Form Submission to the event selector used by the merged Webflow trigger block. |
| apps/tradinggoose/triggers/webflow/form_submission.ts | Scopes form-specific configuration fields to the form-submission trigger. |
| apps/tradinggoose/widgets/widgets/editor_workflow/components/workflow-block/components/sub-block/sub-block-layout.test.ts | Adds real-registry regression coverage for multi-trigger selector and field isolation behavior. |
| apps/tradinggoose/triggers/index.test.ts | Verifies generated shell controls retain trigger ownership when no dropdown is generated. |
Prompt To Fix All With AI
### Issue 1
apps/tradinggoose/triggers/index.ts:179-182
**Missing staging changelog entry**
This staging-targeted PR does not add the required dated file under `changelog/`, leaving the trigger-editor behavior change out of the repository’s release and design history.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(triggers): streamline trigger condit..." | Re-trigger Greptile
Summary
Why
Multi-trigger editors could render fields belonging to sibling trigger variants simultaneously. This made Webflow trigger configuration unclear and could surface duplicate controls. The change keeps each event’s fields isolated to the active selection.
Affected Areas
apps/tradinggooseapps/docspackages/*Issue
fix #199 issue
None.
Validation
Passed: 2 test files, 21 tests.
Risk / Rollout Notes
Low risk. This only changes trigger-field visibility and selector options in the editor; it has no schema, API, or webhook-provider behavior changes.
Backout: revert commit
bad98753c.Config / Data Changes
Checklist
Summary by CodeRabbit
New Features
Bug Fixes