Skip to content

fix(triggers): scope editor fields to selected event - #200

Merged
TradingGoose-Dev merged 1 commit into
stagingfrom
fix/tigger-editor-layout
Aug 18, 2026
Merged

fix(triggers): scope editor fields to selected event#200
TradingGoose-Dev merged 1 commit into
stagingfrom
fix/tigger-editor-layout

Conversation

@BruzWJ

@BruzWJ BruzWJ commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Scope generated trigger editor controls to their selected trigger, preventing sibling trigger fields from rendering together.
  • Add Form Submission to the Webflow trigger selector.
  • Scope Webflow form-submission fields to that event and add regression coverage for multi-trigger editor layouts.

Why

Multi-trigger editors could render fields belonging to sibling trigger variants simultaneously. This made Webflow trigger configuration unclear and could surface duplicate controls. The change keeps each event’s fields isolated to the active selection.

Affected Areas

  • apps/tradinggoose
  • apps/docs
  • packages/*
  • Workflows / execution
  • Realtime / sockets
  • Market data / charting
  • Dev tooling / CI / infra
  • Documentation only
  • Other:

Issue

fix #199 issue

None.

Validation

cd apps/tradinggoose
bun run test -- triggers/index.test.ts widgets/widgets/editor_workflow/components/workflow-block/components/sub-block/sub-block-layout.test.ts

Passed: 2 test files, 21 tests.

Risk / Rollout Notes

Low risk. This only changes trigger-field visibility and selector options in the editor; it has no schema, API, or webhook-provider behavior changes.

Backout: revert commit bad98753c.

Config / Data Changes

  • Env vars added or changed: None.
  • Database schema or migration impact: None.
  • External services or provider behavior changed: None.

Checklist

  • I kept the change focused and reviewed my own diff
  • I validated the change locally and documented the results above
  • I updated docs, examples, or copy if behavior/user-facing flows changed
  • I called out any env, schema, provider, or rollout impact
  • I did not include secrets, tokens, or private credentials in this PR

Summary by CodeRabbit

  • New Features

    • Added a Webflow Form Submission trigger option.
    • Added configuration fields for Webflow credentials, site, and form selection when using the Form Submission trigger.
  • Bug Fixes

    • Trigger-specific settings now remain correctly associated with the selected trigger, including webhook display, save, and instruction options.
    • Improved field visibility so settings for one trigger type do not appear for another.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 62748e72-8105-414b-9874-84e51080f6cd

📥 Commits

Reviewing files that changed from the base of the PR and between 35c4033 and bad9875.

📒 Files selected for processing (5)
  • apps/tradinggoose/triggers/index.test.ts
  • apps/tradinggoose/triggers/index.ts
  • apps/tradinggoose/triggers/webflow/collection_item_created.ts
  • apps/tradinggoose/triggers/webflow/form_submission.ts
  • apps/tradinggoose/widgets/widgets/editor_workflow/components/workflow-block/components/sub-block/sub-block-layout.test.ts

Included review availability: Your plan provides up to 3 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change prevents duplicate trigger inputs by applying selected-trigger conditions consistently. It adds the Webflow form submission trigger and scopes its configuration fields. Tests cover trigger field uniqueness and Webflow field visibility.

Changes

Trigger visibility

Layer / File(s) Summary
Selected-trigger condition generation
apps/tradinggoose/triggers/index.ts, apps/tradinggoose/triggers/index.test.ts
buildTriggerSubBlocks always assigns a selectedTriggerId condition. Tests verify generated field ownership and conditions.
Webflow form submission fields
apps/tradinggoose/triggers/webflow/collection_item_created.ts, apps/tradinggoose/triggers/webflow/form_submission.ts
The Webflow selector includes webflow_form_submission. Credentials, site, and form ID fields display only for that trigger.
Trigger-specific visibility tests
apps/tradinggoose/widgets/widgets/editor_workflow/components/workflow-block/components/sub-block/sub-block-layout.test.ts
Tests use registered block configurations to verify unique trigger fields, complete selector options, and mutually exclusive Webflow fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to bad98

This change limits trigger editor fields to the selected event and adds Webflow form submission support without changing schemas, APIs, or provider behavior. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: scoping trigger editor fields to the selected event.
Linked Issues check ✅ Passed The changes scope trigger fields to the active event and address duplicated parameter inputs reported in issue #199.
Out of Scope Changes check ✅ Passed All code and test changes support trigger field scoping and the Webflow Form Submission option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR scopes generated trigger controls to the active trigger and makes Webflow Form Submission selectable in multi-trigger editors.

  • Applies selected-trigger conditions to generated trigger shell controls.
  • Scopes Webflow form credentials, site, and form fields to the form-submission event.
  • Adds registry-backed regression tests for selector completeness and sibling-field isolation.

Confidence Score: 4/5

The code changes appear safe to merge after adding the repository-required dated changelog entry.

Trigger registration, availability, merged subblock assembly, condition filtering, and save resolution remain aligned; the only accepted issue is the missing staging changelog entry.

Files Needing Attention: apps/tradinggoose/triggers/index.ts

Important Files Changed

Filename Overview
apps/tradinggoose/triggers/index.ts Generated trigger shell fields now consistently inherit the selected-trigger condition.
apps/tradinggoose/triggers/webflow/collection_item_created.ts Adds Webflow Form Submission to the event selector used by the merged Webflow trigger block.
apps/tradinggoose/triggers/webflow/form_submission.ts Scopes form-specific configuration fields to the form-submission trigger.
apps/tradinggoose/widgets/widgets/editor_workflow/components/workflow-block/components/sub-block/sub-block-layout.test.ts Adds real-registry regression coverage for multi-trigger selector and field isolation behavior.
apps/tradinggoose/triggers/index.test.ts Verifies generated shell controls retain trigger ownership when no dropdown is generated.

Fix all with Greploop Fix All in Codex Fix All in Claude Code Fix All in Cursor

Prompt To Fix All With AI
### Issue 1
apps/tradinggoose/triggers/index.ts:179-182
**Missing staging changelog entry**

This staging-targeted PR does not add the required dated file under `changelog/`, leaving the trigger-editor behavior change out of the repository’s release and design history.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix(triggers): streamline trigger condit..." | Re-trigger Greptile

@TradingGoose-Dev
TradingGoose-Dev merged commit ca5b60d into staging Aug 18, 2026
2 checks passed
@TradingGoose-Dev
TradingGoose-Dev deleted the fix/tigger-editor-layout branch August 18, 2026 21:46
BruzWJ added a commit that referenced this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants