fix Option<Self> in function/method parameters and returns#30
Merged
Conversation
Owner
|
Good catch, this was a bit of an oversite on my part and I missed this happening when I added Assume there is a
The test may seem like it has a lot of setup, but it seems correct. |
Tired-Fox
requested changes
Apr 24, 2026
Owner
|
I also think it could happen with Arc, Mutex, etc. This would be the case if This PR can focus on fixing the Option case. I can create another PR for the rest |
Tired-Fox
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when registering a type that has methods that take or return
Option<Self>in a Definition, we get a stack overflow, because it will callTy::ty()in an infinite recursion loop. This should fix this case.I also added some tests, but they are a little convoluted, as I couldn't find a really good way to test this. Feel free to make suggestions how to adapt or edit directly.