Support HTTPS and IDNA domains; bump edition/version; add CI and tests#3
Support HTTPS and IDNA domains; bump edition/version; add CI and tests#3code-tc wants to merge 3 commits into
Conversation
💡 Codex ReviewLine 377 in ff528b6
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
Description
Protocol::HTTPS, accepthttps://inHost/Linkparsing, and updateProtocolordering and display to includehttps.Address::Domainand useidna::domain_to_asciito validate/normalize domain names, updatingAddressordering,GetSize,as_ip, andis_localhostaccordingly.Host::from_strto detect protocol (httpvshttps) and to distinguish IPv4/IPv6 vs domain names, returning normalized ASCII domains when applicable.versionto0.5.0,editionto2024, adjust dependency entries (destream,hr-id, addidna), and add a GitHub Actions workflow at.github/workflows/ci.ymlthat runscargo testfor default and--all-features.Host/Link(including IDN normalization and invalid domain handling) and small compile-time tests assertingserde/destreamimpl availability insrc/lib.rs,src/serial.rs, andsrc/stream.rs.Testing
cargo test --verboseto execute unit tests with default features, and the test suite completed successfully.cargo test --all-features --verboseto validate behavior with optional features enabled, and the test suite completed successfully.CIwas added to run the same tests onpushandpull_requestevents.Codex Task