move the tensor module under a new collection module in the Python client#75
Open
code-tc wants to merge 1 commit into
Open
move the tensor module under a new collection module in the Python client#75code-tc wants to merge 1 commit into
code-tc wants to merge 1 commit into
Conversation
AlekseiChirkovVention
requested changes
Jul 22, 2026
AlekseiChirkovVention
left a comment
AlekseiChirkovVention
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just two minor comments
| assert reduced.values == [3.0, 7.0] | ||
|
|
||
| transpose_source = tc.Tensor(native=dense_u64([2, 3, 2], list(range(12)))) | ||
| transpose_source = tc.Tensor(native=dense_f64([2, 3, 2], [float(v) for v in range(12)])) |
Collaborator
There was a problem hiding this comment.
Tensor decoding still explicitly supports u64, but this removes the only end-to-end transpose assertion for that dtype. Would you mind keeping the u64 case or add a separate u64 transpose test
Comment on lines
+185
to
+187
| `Tensor` now lives under `tinychain.collection` (`tc.collection.Tensor`), with | ||
| `Tensor` now lives under `tinychain.collection` (`tc.collection.Tensor`), and `tc.Tensor` is the canonical shorthand. | ||
|
|
Collaborator
There was a problem hiding this comment.
repeats “Tensor now lives under tinychain.collection” on two consecutive lines; remove the duplicate fragment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prepares to support the
BTreeandTablecollection types, which will be defined alongsideTensorin thecollectionmodule