Corgi backend fixes - #850
Draft
frankmcsherry wants to merge 2 commits into
Draft
Conversation
Term::Proj lowered to Op::Field unconditionally, but Proj on a List means indexing and Field is product-elimination-only (panicked in value.rs). compile_projection now guards with a total place-shape resolver. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Columns carry exactly one shape; infer_shape_cols/transcode assumed row 0's arity for every row, truncating or panicking depending on row order — worst case a silent wrong answer (distinct over truncated rows invents a row). assert_uniform enforces the contract with a message naming the offending row and the remedy (pad to one arity, or use --backend=vec). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.