Add visual regression CI with SwiftShader#2
Merged
Conversation
8053217 to
b3b2953
Compare
- GitHub Actions workflow with 3 jobs: 1. Compare committed D3D11 vs Vulkan reference PNGs (no GPU) 2. Build CaptureVulkan + render with SwiftShader, compare against D3D11 3. Staleness check: warn if Vulkan source changed without reference update - Reference PNGs for 21 test cases (D3D11 + Vulkan, 4 frames each) - compare_reference.py: CI-friendly orchestrator for image comparison - update_reference.py: developer tool to refresh reference images - compare_images.py: added PNG reading support (pure stdlib) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GitHub Actions windows-latest has VS 2022 Enterprise, not Community. Use vswhere.exe to find the VS installation dynamically, with hardcoded paths as fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Vulkan property sheet (GFx_Renderer_Vulkan.props) uses $(VK_SDK_PATH) for include/lib paths, but CI only set VULKAN_SDK. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
22c8ee2 to
7fc2e7e
Compare
Added -SkipD3D11 flag to build_tests.ps1. CI only needs CaptureVulkan for SwiftShader rendering — D3D11 libs aren't available on the runner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The SwiftShader job rebuilds Vulkan from source and compares live captures against D3D11 references, making the staleness heuristic redundant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The SwiftShader capture job builds from source and compares live renders against D3D11 references — no need for a separate static PNG comparison. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
compare-referencesjob passes with committed PNGsswiftshader-capturejob builds CaptureVulkan and renders correctlystaleness-checkwarns when Vulkan source changes without reference updateworkflow_dispatchtrigger🤖 Generated with Claude Code