Skip to content

add melonly integration#5

Open
finaIcutpro wants to merge 3 commits into
TicketsBot-cloud:mainfrom
finaIcutpro:main
Open

add melonly integration#5
finaIcutpro wants to merge 3 commits into
TicketsBot-cloud:mainfrom
finaIcutpro:main

Conversation

@finaIcutpro

@finaIcutpro finaIcutpro commented May 12, 2026

Copy link
Copy Markdown

Description

This PR adds Melonly's verification module to TicketsBot integration.

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

I ran node --check and tested the worker on my own Cloudflare account.

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@finaIcutpro finaIcutpro requested a review from a team as a code owner May 12, 2026 13:45
@finaIcutpro

finaIcutpro commented May 12, 2026

Copy link
Copy Markdown
Author

Note: This feature requires a specific global API token. TicketsBot team, please reach out to me @ finalcutpro on Discord to get this token

@biast12

biast12 commented May 12, 2026

Copy link
Copy Markdown
Contributor

I was just about to say, would you mind joining our support server and opening a general ticket?
https://discord.com/invite/ticketsbot

@biast12 biast12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, this looks good, it does have 1 issue though:
Per the Integration Standards §5, should a validate endpoint only be used if the integration uses per-guild secrets.
Melonly doesn't have any, so the endpoint and function are not needed and should be removed.

Comment thread melonly/index.js Outdated
Comment thread melonly/index.js Outdated
@finaIcutpro

Copy link
Copy Markdown
Author

Thank you for your suggestions. I've made changes to resolve both of your requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants