fix(site): close DOM-XSS in the deployed trace.js#12
Merged
Conversation
The verification artifact's trace.js read claim titles back via .textContent (entities decoded) and re-injected them through innerHTML when building the ledger and verdict pill — re-opening the XSS the server-side escaping closes. The rendering asset copy was fixed in PR #10; the site/ source-of-truth original was missed. Build the row/pill with createElement + textContent only. Also gitignore the .playwright-mcp browser-verification artifacts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification artifact's
site/trace.jsread claim titles back via.textContent(entities decoded) then re-injected them throughinnerHTMLwhen building the ledger and verdict pill — re-opening the DOM-XSS that server-side escaping closes. The rendering asset copy was fixed in #10; thesite/source-of-truth original (deployed to the demo site) was missed. Now builds the row/pill withcreateElement+textContentonly.Also gitignores the
.playwright-mcp/browser-verification artifacts.🤖 Generated with Claude Code