feat: Add Multi-Stage Server Image With Non-Root Healthcheck - #18
Open
ThomasHartDev wants to merge 1 commit into
Open
feat: Add Multi-Stage Server Image With Non-Root Healthcheck#18ThomasHartDev wants to merge 1 commit into
ThomasHartDev wants to merge 1 commit into
Conversation
Ship apps/server as a four-stage image: lockfile install, compile, pnpm deploy --prod, then a slim runtime as uid 999. HEALTHCHECK hits /healthz on loopback. A small parser fails tests if the recipe is single-stage, root, or HEALTHCHECK NONE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server had a health endpoint and no image. This adds apps/server/Dockerfile as four stages: lockfile install, compile plus pnpm deploy --prod, then a slim runtime that drops to uid 999 and probes GET /healthz on 127.0.0.1. The repo-root .dockerignore keeps git, node_modules, and env files out of the daemon context.
image-policy.ts parses the recipe so CI can fail if the final stage is root, has HEALTHCHECK NONE, uses ADD, or bakes a secret into ENV/ARG. Built the image locally, ran as agent (uid 999), and got {"status":"ok"} from /healthz.
Closes #17