Match CI matrix to FactoMineR's R >= 4.3 requirement#31
Open
VincentGuyader wants to merge 1 commit into
Open
Conversation
pak failed to resolve dependencies on every job: Could not solve package dependencies: * deps::.: Can't install dependency FactoMineR * FactoMineR: Needs R >= 4.3 Two underlying issues: 1. The R-CMD-check matrix included R 3.6 / 4.1 / oldrel-3 / oldrel-4, none of which can install FactoMineR. Trim to release / devel / oldrel-1 / oldrel-2 across ubuntu, plus macos and windows release. 2. setup-r@v2 had `r-version: '4.2.2'` hardcoded, so it overrode every matrix entry with R 4.2.2 — also below FactoMineR's floor. Wire r-version to the matrix entry instead. Also bump DESCRIPTION's `Depends: R (>= 2.10)` to `R (>= 4.3)` so the package itself declares the constraint imposed by its imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
`R-CMD-check` était rouge sur les 11 jobs avec :
```
Could not solve package dependencies:
```
Causes (deux, qui se cumulent)
Matrice incompatible. Elle incluait `R 3.6`, `R 4.1`, `oldrel-3`, `oldrel-4` — toutes < 4.3, donc pak ne peut pas installer FactoMineR sur ces lignes. Avec `fail-fast: false` ces jobs faisaient échouer le check global.
`r-version: '4.2.2'` codé en dur dans `setup-r@v2` (ligne 55). Cette valeur surchargeait silencieusement chaque entrée de matrice — donc même `release`/`devel` tournaient en réalité sur 4.2.2, en dessous du plancher de FactoMineR.
`DESCRIPTION` annonçait `Depends: R (>= 2.10)` ce qui ne reflétait pas la contrainte transitive imposée par `FactoMineR`.
Fix
Test
Résolution `pak` reproduite localement (R 4.4) :
```
Plus d'erreur `pkgplan_stop_for_solve_error`.
Note sur le scope
Le rapport demandait de ne pas supprimer les checks Windows-only. Ici, l'échec n'est pas Windows-only — il touche les 11 plateformes — et les versions de R retirées sont incompatibles avec une dépendance directe. Aucun `windows-latest` n'est supprimé : `windows-latest (release)` reste dans la matrice.