fix(sample_source_call): respect local argument (#9)#13
Open
VincentGuyader wants to merge 3 commits into
Open
Conversation
sample_source_call() was always returning the French-locale list
('Local','France','Europe','International'), leaking 'France' as a
source when users passed local='en_US'. Switch the list on the locale
the same way the other sample_* helpers do, so en_US now yields
'Local','US','Europe','International'.
Aligns sample_source_call() with the rest of the file's locale handling and turns silent fallthrough on unknown locales (e.g. local = 'de_DE') into an explicit error instead of yielding the en_US list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample_source_call()was always returning the French-locale list (Local,France,Europe,International) regardless of thelocal =argument, leakingFranceinto datasets generated withlocal = "en_US". Branched on the locale soen_USnow yieldsLocal,US,Europe,International.local =is now declared withmatch.arg(), matching the rest of the file's contract: any unsupported locale (e.g."de_DE") errors out instead of silently falling through toen_US.Test plan
tests/testthat/test-locale.R: 6 PASS, including an explicit assertion thatFrancedoes not appear in theen_USfactor levels and a regression on the unknown-locale rejection.Closes #9